feat: Add modify function to the GuildMemberRoleManager for adding/removing roles at once.

packages/discord.js/src/managers/GuildMemberRoleManager.js

@@ -107,14 +107,7 @@ class GuildMemberRoleManager extends DataManager {
    */
   async add(roleOrRoles, reason) {
     if (roleOrRoles instanceof Collection || Array.isArray(roleOrRoles)) {
-      const resolvedRoles = [];
-      for (const role of roleOrRoles.values()) {
-        const resolvedRole = this.guild.roles.resolveId(role);
-        if (!resolvedRole) {
-          throw new DiscordjsTypeError(ErrorCodes.InvalidElement, 'Array or Collection', 'roles', role);
-        }
-        resolvedRoles.push(resolvedRole);
-      }
+      const resolvedRoles = this.resolveRoles(roleOrRoles);
 
       const newRoles = [...new Set(resolvedRoles.concat(...this.cache.keys()))];
       return this.set(newRoles, reason);
@@ -144,14 +137,7 @@ class GuildMemberRoleManager extends DataManager {
    */
   async remove(roleOrRoles, reason) {
     if (roleOrRoles instanceof Collection || Array.isArray(roleOrRoles)) {
-      const resolvedRoles = [];
-      for (const role of roleOrRoles.values()) {
-        const resolvedRole = this.guild.roles.resolveId(role);
-        if (!resolvedRole) {
-          throw new DiscordjsTypeError(ErrorCodes.InvalidElement, 'Array or Collection', 'roles', role);
-        }
-        resolvedRoles.push(resolvedRole);
-      }
+      const resolvedRoles = this.resolveRoles(roleOrRoles);
 
       const newRoles = this.cache.filter(role => !resolvedRoles.includes(role.id));
       return this.set(newRoles, reason);
@@ -174,6 +160,52 @@ class GuildMemberRoleManager extends DataManager {
     }
   }
 
+  /**
+   * @typedef {Object} ModifyGuildMemberRolesOptions
+   * @property {Readonly<RoleResolvable[]> | ReadonlyCollection<Snowflake, Role>} [rolesToAdd] The roles to add
+   * @property {Readonly<RoleResolvable[]> | ReadonlyCollection<Snowflake, Role>} [rolesToRemove] The roles to remove
+   * @property {Readonly<RoleResolvable[]> | ReadonlyCollection<Snowflake, Role>} [reason] Reason for modifying
+   * the roles
+   */
+
+  /**
+   * Modifies the roles of the member.
+   * @param {ModifyGuildMemberRolesOptions} [options] Options for modifying the roles
+   * @returns {GuildMember}
+   */
+  modify(options) {
+    const resolvedRolesToAdd = this.resolveRoles(options.rolesToAdd);
+    const resolvedRolesToRemove = this.resolveRoles(options.rolesToRemove);
+
+    const currentRoles = new Set(this.member.roles.cache.keys());
+    for (const role of resolvedRolesToAdd) {
+      currentRoles.add(role.id);
+    }
+    for (const role of resolvedRolesToRemove) {
+      currentRoles.delete(role.id);
+    }
+
+    return this.member.roles.set([...currentRoles], options.reason);
+  }
+
+  /**
+   * Resolves roles from the input.
+   * @param {RoleResolvable[] | Collection<Snowflake, Role>} rolesToResolve The roles to resolve
+   * @returns {Array} The resolved roles
+   * @private
+   */
+  resolveRoles(rolesToResolve) {
+    const resolvedRoles = [];
+    for (const role of rolesToResolve.values()) {
+      const resolvedRole = this.guild.roles.resolveId(role);
+      if (!resolvedRole) {
+        throw new DiscordjsTypeError(ErrorCodes.InvalidElement, 'Array or Collection', 'roles', role);
+      }
+      resolvedRoles.push(resolvedRole);
+    }
+    return resolvedRoles;
+  }
+
   /**
    * Sets the roles applied to the member.
    * @param {Collection<Snowflake, Role>|RoleResolvable[]} roles The roles or role ids to apply

packages/discord.js/typings/index.d.ts

@@ -4393,6 +4393,12 @@ export class GuildStickerManager extends CachedManager<Snowflake, Sticker, Stick
   public fetchUser(sticker: StickerResolvable): Promise<User | null>;
 }
 
+export interface ModifyGuildMemberRolesOptions {
+  rolesToAdd?: readonly RoleResolvable[] | ReadonlyCollection<Snowflake, Role>;
+  rolesToRemove?: readonly RoleResolvable[] | ReadonlyCollection<Snowflake, Role>;
+  reason?: string;
+}
+
 export class GuildMemberRoleManager extends DataManager<Snowflake, Role, RoleResolvable> {
   private constructor(member: GuildMember);
   public get hoist(): Role | null;
@@ -4408,6 +4414,7 @@ export class GuildMemberRoleManager extends DataManager<Snowflake, Role, RoleRes
     roleOrRoles: RoleResolvable | readonly RoleResolvable[] | ReadonlyCollection<Snowflake, Role>,
     reason?: string,
   ): Promise<GuildMember>;
+  public modify(options: ModifyGuildMemberRolesOptions): Promise<GuildMember>;
   public set(
     roles: readonly RoleResolvable[] | ReadonlyCollection<Snowflake, Role>,
     reason?: string,