Skip to content

ci: fix coverage upload #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

ci: fix coverage upload #10331

merged 1 commit into from
Jun 7, 2024

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jun 7, 2024

Please describe the changes this PR makes and why it should be merged:
#10270 updated the codecov action version which uses the cli now. the cli searches for files by default and still does even with the file option???? This should disable that so that the coverage reports properly again (hoping we don't have to delete all the coverage data for this to report properly)

Status and versioning classification:

@ckohen ckohen requested a review from a team as a code owner June 7, 2024 03:08
@ckohen ckohen requested review from iCrawl and Jiralite June 7, 2024 03:08
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 3:08am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 3:08am

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.36%. Comparing base (346d1be) to head (640a567).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10331      +/-   ##
==========================================
+ Coverage   19.13%   19.36%   +0.23%     
==========================================
  Files          31       32       +1     
  Lines        6250     6268      +18     
  Branches      111      115       +4     
==========================================
+ Hits         1196     1214      +18     
  Misses       5054     5054              
Flag Coverage Δ
utilities 100.00% <ø> (+80.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite added the ci label Jun 7, 2024
@kodiakhq kodiakhq bot merged commit 4f174c6 into discordjs:main Jun 7, 2024
22 of 23 checks passed
@ckohen ckohen deleted the ci/fix-codecov branch June 7, 2024 12:49
vladfrangu pushed a commit that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants