Skip to content

fix(Message): properly compare attachments and embeds #10282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2024
Merged

fix(Message): properly compare attachments and embeds #10282

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
292b74a
fix(Message): properly compare `attachments` and `embeds`
sdanialraza May 18, 2024
156fcdc
refactor: use `has` instead of `get`
sdanialraza May 19, 2024
90e4b9a
refactor: keep length checks
sdanialraza May 24, 2024
0b3bc31
Merge branch 'main' into fix/properly-compare-attachments-embeds
kodiakhq[bot] May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/discord.js/src/structures/Message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,10 +973,12 @@ class Message extends Base {
this.id === message.id &&
this.author.id === message.author.id &&
this.content === message.content &&
this.tts === message.tts &&
this.nonce === message.nonce &&
this.tts === message.tts &&
this.attachments.size === message.attachments.size &&
this.embeds.length === message.embeds.length &&
this.attachments.length === message.attachments.length;
this.attachments.every(attachment => message.attachments.has(attachment.id)) &&
this.embeds.every((embed, index) => embed.equals(message.embeds[index]));

if (equal && rawData) {
equal =
Expand Down
Loading