Skip to content

csp policy fix for worker #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

csp policy fix for worker #1926

wants to merge 1 commit into from

Conversation

sfahad1414
Copy link
Collaborator

@sfahad1414 sfahad1414 commented Apr 22, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced Content Security Policy to explicitly allow web workers from the same origin and blob URLs, improving compatibility with features that utilize web workers.

Copy link

coderabbitai bot commented Apr 22, 2025

Walkthrough

The Content Security Policy (CSP) configuration was updated across multiple modules to include a new worker_src directive. This directive allows web workers to be loaded from the same origin ('self') and from blob URLs ("blob:"). No other logic, error handling, or control flow was changed in any of the affected files, and there were no alterations to public or exported entities.

Changes

Files Change Summary
kairon/actions/server.py
kairon/api/app/main.py
kairon/chat/server.py
Updated CSP configuration to add worker_src directive for 'self' and "blob:" sources.
kairon/async_callback/main.py
kairon/evaluator/main.py
kairon/events/server.py
kairon/history/main.py
Extended CSP configuration with .worker_src("'self'", "blob:") to permit web workers from same origin and blob URLs.

Poem

In the warren of code, a policy grew,
Now workers may hop from blob URLs too!
With 'self' and with "blob:", the rules are precise,
Security’s tight, but the workers play nice.
So here’s to the CSP, updated anew—
A safer, hoppier world for all code to pursue!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b247a43 and 338cc08.

📒 Files selected for processing (7)
  • kairon/actions/server.py (1 hunks)
  • kairon/api/app/main.py (1 hunks)
  • kairon/async_callback/main.py (1 hunks)
  • kairon/chat/server.py (1 hunks)
  • kairon/evaluator/main.py (1 hunks)
  • kairon/events/server.py (1 hunks)
  • kairon/history/main.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Python CI
  • GitHub Check: Analyze (python)
🔇 Additional comments (6)
kairon/events/server.py (1)

35-35: Content Security Policy updated to support web workers.

Added worker_src directive to allow loading web workers from the same origin and blob URLs, which is necessary for proper operation of web workers in modern browsers.

kairon/history/main.py (1)

38-38: Content Security Policy enhanced for web worker support.

Added worker_src directive with appropriate sources ('self' and "blob:") to enable proper web worker functionality.

kairon/chat/server.py (1)

50-50: Web worker security configuration added.

The CSP configuration has been properly updated to include the worker_src directive, maintaining consistent security policies across the application.

kairon/api/app/main.py (1)

47-47: Added web worker source directive to CSP.

This change aligns the CSP configuration with modern security best practices by explicitly defining allowed sources for web workers.

kairon/actions/server.py (1)

61-61: Content Security Policy updated for web worker compatibility.

The addition of worker_src directive completes the consistent implementation of web worker support across all server modules.

kairon/evaluator/main.py (1)

28-28: Approve CSP worker-src directive addition
The addition of .worker_src("'self'", "blob:") correctly extends the allowed sources for web workers in the FastAPI secure headers.

@@ -49,6 +49,7 @@ async def shutdown(app: Application):
.connect_src("'self' api.spam.com")
.frame_src("'self'")
.img_src("'self'", "static.spam.com")
.worker_src("'self'", "blob:")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ensure CSP builder and manual config are in sync with worker-src
The worker_src("'self'", "blob:") directive was added to the CSP builder chain, but the csp_config used by generate_csp_header lacks a corresponding "worker-src" entry. Add "worker-src": ["'self'", "blob:"] to csp_config to maintain consistency.

@sfahad1414 sfahad1414 closed this May 13, 2025
@sfahad1414 sfahad1414 deleted the worker-csp-policy-fix branch May 13, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant