- form_validation issue fixed: as validation action was not consideri…

[hiteshghuge]

…ng into training

Summary by CodeRabbit

• Bug Fixes
  • Ensured that all actions starting with "validate_" are always included in training actions, improving reliability of validation processes.

[coderabbitai]

Walkthrough

The __prepare_training_actions method in the MongoProcessor class was updated to ensure that all actions starting with "validate_" are always included in the list of training actions. Previously, only actions present in the required actions from the story graphs were returned. Now, the method collects all "validate_" actions from the full action list and appends them to the filtered list, guaranteeing their inclusion regardless of their presence in the story graphs. The method's signature remains unchanged.

Changes

File(s)	Change Summary
kairon/shared/data/processor.py	Modified __prepare_training_actions to always include actions starting with "validate_" in its output.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MongoProcessor
    participant StoryGraphs

    User->>MongoProcessor: Call __prepare_training_actions(bot, story_graphs)
    MongoProcessor->>StoryGraphs: Extract required actions from story graphs
    MongoProcessor->>MongoProcessor: Get all actions for the bot
    MongoProcessor->>MongoProcessor: Filter actions starting with "validate_"
    MongoProcessor->>MongoProcessor: Combine required actions and validation actions
    MongoProcessor-->>User: Return combined action list

Loading

Possibly related PRs

• form validation action fix #1495: Modifies the add_action method to handle an additional action_type parameter for form validation, relating to how validation actions are managed in the same file.

Poem

In the warren where actions are spun,
Now "validate_" hops in with everyone.
No longer left out in the training parade,
Validation’s importance is now displayed.
With every action counted, none go astray—
The bot’s better prepared for another fine day!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ceadd41 and ce1c751.

📒 Files selected for processing (1)

• kairon/shared/data/processor.py (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

kairon/shared/data/processor.py (1)

kairon/importer/validator/file_validator.py (1)

• validate_actions (1036-1047)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Analyze (python)
• GitHub Check: Python CI

🔇 Additional comments (1)

kairon/shared/data/processor.py (1)

1484-1486: Great fix to ensure validation actions are included in training!

This change ensures that all actions starting with "validate_" are always included in the training actions list, regardless of whether they appear in the story graphs. This addresses the issue where form validation actions were not being considered during training, which could have led to validation failures at runtime.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sfahad1414]

Approved

[sushantpatade]

Approved