Skip to content

⬆️ Upgrade wallet-group-id plugin and cloudcontroller #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 6, 2025

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented May 6, 2025

I'm busy regenerating the cloudcontroller with Cheqd endpoints, and noticed the group-id plugin models should be updated

plugin changes: didx-xyz/acapy-wallet-groups-plugin#80
cloudcontroller changes: didx-xyz/aries-cloudcontroller-python#246


Includes model renames / refactoring for Create/Update tenant requests. (Note: does not impact API spec, because these cloudcontroller models are used internally, and not in client-side request bodies -- the openapi changes are for cheqd being added to supported DID methods, from cloudcontroller update)

@ff137 ff137 force-pushed the update-group-id-plugin branch from d448177 to 66ddc54 Compare May 6, 2025 10:30
@ff137 ff137 marked this pull request as ready for review May 6, 2025 11:04
@ff137 ff137 self-assigned this May 6, 2025
@ff137 ff137 changed the title 🚧 Update wallet-group-id plugin ⬆️ Update wallet-group-id plugin May 6, 2025
Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140092% 

Tests Skipped Failures Errors Time
1011 7 💤 0 ❌ 0 🔥 6m 48s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140492% 

Tests Skipped Failures Errors Time
1011 40 💤 0 ❌ 0 🔥 4m 56s ⏱️

@ff137 ff137 requested a review from cl0ete May 6, 2025 12:15
Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140092% 

Tests Skipped Failures Errors Time
1011 7 💤 0 ❌ 0 🔥 7m 4s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140492% 

Tests Skipped Failures Errors Time
1011 40 💤 0 ❌ 0 🔥 5m 4s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140092% 

Tests Skipped Failures Errors Time
1011 7 💤 0 ❌ 0 🔥 7m 28s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140492% 

Tests Skipped Failures Errors Time
1011 40 💤 0 ❌ 0 🔥 5m 20s ⏱️

@didx-devops
Copy link
Contributor

didx-devops bot commented May 6, 2025

✅ All OpenAPI Specifications are in sync

No differences were detected in the OpenAPI specifications.

Copy link

sonarqubecloud bot commented May 6, 2025

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140092% 

Tests Skipped Failures Errors Time
1011 7 💤 0 ❌ 1 🔥 7m 10s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140492% 

Tests Skipped Failures Errors Time
1011 40 💤 0 ❌ 0 🔥 5m 25s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140092% 

Tests Skipped Failures Errors Time
1011 7 💤 0 ❌ 0 🔥 7m 25s ⏱️

Copy link

github-actions bot commented May 6, 2025

Coverage

K8s Regression Test Coverage
FileStmtsMissCoverMissing
app
   main.py80298%121–122
app/models
   issuer.py76199%45
   verifier.py98694%62, 74, 123, 130, 143, 156
   wallet.py36489%100–105
app/routes
   connections.py84199%198
   issuer.py119298%99, 194
   jsonld.py604722%23–93, 104–137
   messaging.py241154%43–52, 85–95
   trust_registry.py62297%52–53
app/routes/wallet
   credentials.py805334%57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
   acapy_wallet.py40490%60–61, 98–99
   revocation_registry.py207598%250–254, 433–437
app/services/definitions
   schemas.py79199%69
app/services/onboarding
   tenants.py634922%34–107, 117–147
app/services/onboarding/util
   set_endorser_metadata.py724044%32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
   actors.py107992%95–100, 110, 209–210, 212–217, 282–285
   schemas.py54983%57–63, 89–99
app/services/trust_registry/util
   actor.py31294%26–27
app/util
   assert_public_did.py18856%17–33
   credentials.py14286%13, 18
   retry_method.py361558%20–35, 76–77, 91–103
   save_exchange_record.py13192%29
   string.py15473%15–16, 20, 24
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
   transaction_acked.py14286%34–35
shared
   log_config.py532062%41–94, 103–110, 152, 161–173
shared/models
   connection_record.py24196%47
   endorsement.py876921%36–70, 94–124, 134–183
   protocol.py10190%18
   trustregistry.py63789%22, 44, 75–83
shared/util
   api_router.py14193%17
   mock_agent_controller.py53198%26
trustregistry
   main.py84495%49–51, 113
waypoint
   main.py50198%67
waypoint/services
   nats_service.py137299%212–213
TOTAL533140492% 

Tests Skipped Failures Errors Time
1011 40 💤 0 ❌ 0 🔥 5m 26s ⏱️

@ff137 ff137 changed the title ⬆️ Update wallet-group-id plugin ⬆️ Upgrade wallet-group-id plugin and cloudcontroller May 6, 2025
@ff137 ff137 merged commit d2033f8 into master May 6, 2025
59 checks passed
@ff137 ff137 deleted the update-group-id-plugin branch May 6, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants