fix: While a text event starts which changes the portrait, the new character portrait scene is created after the signal text_started is emited #2678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix just awaits the change_speaker and change_character_portrait calls so it instantiates the new character portrait scene before the calling the text_started and about_to_show_text signals.
I think it makes more sense if when changing the portrait, the latest portrait character scene is there to receive the signal.