Skip to content

Conversation

cliveglitch
Copy link

@cliveglitch cliveglitch commented Oct 8, 2025

This fix just awaits the change_speaker and change_character_portrait calls so it instantiates the new character portrait scene before the calling the text_started and about_to_show_text signals.

I think it makes more sense if when changing the portrait, the latest portrait character scene is there to receive the signal.

…e info Dictionary will return the outdated portrait info instead of the latest
@cliveglitch cliveglitch changed the title fix: While text event starts which changes the portrait, signal text_started sends outdated portrait Dictionary data instead of latest fix: While a text event starts which changes the portrait, the new character portrait scene is created after the signal text_started is emited Oct 8, 2025
@Jowan-Spooner
Copy link
Member

Thanks! It makes sense, but I will have to test this a bit before I feel comfortable, the text event is so damn finicky, reordering/retiming things like this usually mess something up 😭.

@cliveglitch
Copy link
Author

I understand, I don't know if there's a way in gdscript to await the portrait changes just before emitting the signals, kinda like using Javascript Promises, you run them and save the promise in a variable and await it when you need it... that could be an alternative if it breaks something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants