Skip to content

Various Fixes #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 11, 2025
Merged

Various Fixes #2564

merged 21 commits into from
Apr 11, 2025

Conversation

Jowan-Spooner
Copy link
Member

@Jowan-Spooner Jowan-Spooner commented Apr 10, 2025 •
edited
Loading

Through some extensive testing, all of these issues were found and removed:

  • Background Transitions being broken in export
  • Backgrounds broken when quickly skipping
  • Remove warning on container sizes
  • Suggest fade and fade_length in character update event (text editor)
  • Improve/Fix fading on portraits and mirrored portraits
  • Fix warning about character suffix/prefix
  • Fix weird headings in portrait settings
  • Slightly improve character suggestions (text editor)
  • Avoid a bunch of unnecessary warnings
  • Fix character styles not loading
  • Performance improvements (hopefully) and introduction of DialogicStylesUtil
  • Enabled folding gutter in text editor
  • Improve auto-indentation in text editor

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Critical 💩 labels Apr 10, 2025
@Jowan-Spooner
Important fix for character styles
d440b26
@Jowan-Spooner
Fix warnings and improve docs
12daf19
@Jowan-Spooner
Avoid a bunch more unnecessary warnings
1547d00
@Jowan-Spooner
TextTimeline: Improve character suggestions
09a04eb
@Jowan-Spooner
Improve character event position suggestions
27cce1d
@Jowan-Spooner
Fix weird headings in portrait settings
1e6bd48
@Jowan-Spooner
Fix warning about character suffix/prefix
1a33d01
@Jowan-Spooner
Improve/fix cross fade on portraits
df583b0
@Jowan-Spooner
CharacterEvent: Suggest fade and fade_length parameters in text editor
36f09fc
@Jowan-Spooner
Small static typing change
971a37a
@Jowan-Spooner
Try setting container size deferred to avoid warning
196b893
@Jowan-Spooner
Backgrounds: Fix transitions being broken in export
b9ec6d5 
Files once again having a different path at runtime. Damn it godot...
@Jowan-Spooner
Background: Fix for skipping transitions
1b46113
@Jowan-Spooner
Update to godot 4.3 for test workflow
e6faa48
@Jowan-Spooner
Add DialogicStylesUtil and other performance fixes
2ab6612 
The new best way to preload a style is with Dialogic.Styles.preload_style("name_or_path")
@Jowan-Spooner
Try fixing tests again
adeb357
@Jowan-Spooner
Fix warning that is invalid on 4.3
3f7e719
@Jowan-Spooner
Enable folding gutter in timeline text editor
3a4db80
@Jowan-Spooner
Small improvements to text editor
cc4315d
@Jowan-Spooner
try to fix glossary test
f23306c
@Jowan-Spooner
Fix glossary test again
15d9e4a
@Jowan-Spooner Jowan-Spooner merged commit e098088 into dialogic-godot:main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug 🐞 Something isn't working Critical 💩
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jowan-Spooner