Skip to content

fix the node type as AudioStreamPlayer #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/dialogic/Modules/Audio/subsystem_audio.gd
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func update_audio(channel_name:= "", path := "", settings_overrides := {}) -> vo

## Handle previous audio on channel
if is_channel_playing(channel_name):
var prev_audio_node: Node = current_audio_channels[channel_name]
var prev_audio_node: AudioStreamPlayer = current_audio_channels[channel_name]
prev_audio_node.name += "_Prev"
if audio_settings.fade_length > 0.0:
var fade_out_tween: Tween = create_tween()
Expand Down Expand Up @@ -215,7 +215,7 @@ func stop_all_one_shot_sounds() -> void:

## Converts a linear loudness value to decibel and sets that volume to
## the given [param node].
func interpolate_volume_linearly(value: float, node: Node) -> void:
func interpolate_volume_linearly(value: float, node: AudioStreamPlayer) -> void:
node.volume_db = linear_to_db(value)


Expand Down