Fix portrait scaling #2445
Merged
Fix portrait scaling #2445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jowan-Spooner
added
the
Approved
|
This seems like a sensible change. Thank you very much for looking into this and making the PR 🎉! |
LucaVazz
pushed a commit
to LucaVazz/dialogic
that referenced
this pull request
Jun 29, 2025
…/scaled (dialogic-godot#2445) Closes: dialogic-godot#2443 Based on conversation with zaknafean, I checked how this was done in Dialogic 1, and it uses get_viewport().get_visible_rect(), which according to my testing does respect the window stretch mode in Project Settings. More detailed testing may be required, I only tested that the size matches expectations based on the stretch mode settings of disabled and canvas_items. When set to disabled the size reflects the actual window size, but on canvas_items the viewport size is returned instead, regardless of the window size. If I have time for further testing I will post any results as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2443
Based on conversation with @zaknafean, I checked how this was done in Dialogic 1, and it uses
get_viewport().get_visible_rect(), which according to my testing does respect the window stretch mode in Project Settings.More detailed testing may be required, I only tested that the size matches expectations based on the stretch mode settings of
disabledandcanvas_items. When set todisabledthe size reflects the actual window size, but oncanvas_itemsthe viewport size is returned instead, regardless of the window size. If I have time for further testing I will post any results as well.