feat: migrate gix-cmp Collapsible, KeyValuePair and KeyValuePairInfo #7169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to integrate the latest version of Gix-cmp, which includes the migration of
Collapsible,KeyInfoPair, andKeyInfoPairInfoto Svelte v5. Otherwise, the collapsible element may eventually stop working as expected, as it has become incompatible with the latest version of Svelte.Changes in Gix-cmp
Notes
Unfortunately not really a way to size down the PR 😢. Collapsible, KeyValuePair, KeyValuePairInfo and Section are related and using each others so because of the slot migration to snippet, we cannot just migrate one or the other.
Changes
gix-cmp@nextProposalSystemInfoEntryto Svelte v5 to avoid naming clashes onvalue.ExpandableProposalNeuronsandStakeNeuronToVoteto Svelte v5 to use newCollapsible.Tests
None.