bot: Update proposals candid bindings #7113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pr-automation-bot-public[bot]](https://avatars.githubusercontent.com/u/59101585?s=60&v=4){kind=small}
yhabib
approved these changes
Jul 28, 2025
yhabib
approved these changes
Jul 28, 2025
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
…talRequest (#7191) # Motivation A new action proposal, `FulfillSubnetRentalRequest`, has been added. This PR introduces support for the i18n aspect of the proposal, allowing it to be rendered in the nns-dapp. Relevant links: * dfinity/ic-js#993 * #7165 * #7113 * https://github.com/dfinity/ic/pull/5835/files#diff-47cb67467f37606a03f7785a62befc6771b11fa71b463741d6fd826c21f05cb4 # Changes - Add translations to for the new type # Tests - Not possible # Todos - [x] Accessibility (a11y) – any impact? - [x] Changelog – is it needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.
Changes
IC_COMMIT_FOR_PROPOSALSspecified inconfig.json.proposalscandid files to the versions in that commit..didfiles in the proposals payload rendering crate.Tests
Breaking changes are: