Skip to content

misc: Approval bypass v2 oss #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
May 5, 2025
Merged

misc: Approval bypass v2 oss #6510

merged 30 commits into from
May 5, 2025

Conversation

prakash100198
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

kartik-579
kartik-579 requested changes Apr 11, 2025
View reviewed changes
@prakash100198
code review fixes: 1st level kartik
3be33af
@prakash100198
code review fixes: 1st level kartik
d0a7cbc
@prakash100198
code review fixes: 1st level nishant
d1aff8e
@prakash100198
oss sync with ent
353cac8
@prakash100198
resource_version in global policy table
7a2493a
@prakash100198
varchar 50 to 20
5dff7b9
@prakash100198
update col name to policy_revision
26b26c8
@prakash100198
varchar to text policy revision
9962cbd
@prakash100198
GetCmAndSecretBulkUpdateResponseForOneApp new adaptor func
067e9b8
@prakash100198
script fix
fa50887
@prakash100198
GetDeploymentTemplateBulkUpdateResponseForOneApp
6036c8b
@prakash100198
code review corporation :- level 2
03693a4
@prakash100198
revert ArtifactStateWhileDeployment to ImageStateWhileDeployment
d5ff588
@prakash100198
Merge branch 'develop' into approval-bypass-v2-oss
7f42451 
# Conflicts:
#	api/restHandler/app/pipeline/trigger/PipelineTriggerRestHandler.go
#	env_gen.json
#	env_gen.md
#	pkg/deployment/deployedApp/DeployedAppService.go
#	pkg/deployment/trigger/devtronApps/deployStageHandlerCode.go
#	pkg/eventProcessor/in/CDPipelineEventProcessorService.go
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@prakash100198 prakash100198 changed the title Approval bypass v2 oss feat: Approval bypass v2 oss May 5, 2025
@prakash100198 prakash100198 changed the title feat: Approval bypass v2 oss misc: Approval bypass v2 oss May 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025

The migration files have successfully passed the criteria!!

@prakash100198 prakash100198 merged commit aa8800b into develop May 5, 2025
7 of 10 checks passed
@prakash100198 prakash100198 deleted the approval-bypass-v2-oss branch May 5, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@kartik-579 kartik-579 kartik-579 approved these changes

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakash100198 @nishant-d @kartik-579