chore: update backup-n-schedule detail path #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elessar1802
requested review from
vikramdevtron and
vivek-devtron
as code owners
…mon-lib into feat/create-backup
…mon-lib into feat/backup-n-schedule-detail
…bs/devtron-fe-common-lib into feat/create-backup
There was a problem hiding this comment.
Pull Request Overview
This PR updates the routing path for the backup schedule detail page and introduces a new reusable Card component to the shared components library.
- Adds a new Card component with loading states and customizable styling options
- Updates ModalSidebarPanel to conditionally render its content wrapper
- Exports the new Card component from the shared components index
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Components/index.ts | Exports the new Card component |
| src/Shared/Components/ModalSidebarPanel/ModalSidebarPanel.component.tsx | Adds conditional rendering wrapper around sidebar content |
| src/Shared/Components/Card/types.ts | Defines TypeScript types for the Card component |
| src/Shared/Components/Card/index.ts | Exports Card component and its types |
| src/Shared/Components/Card/Card.component.tsx | Implements the Card component with shimmer loading states |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AbhishekA1509
requested changes
Oct 23, 2025
…mon-lib into feat/backup-n-schedule-detail
…bs/devtron-fe-common-lib into feat/create-backup
feat: add Card component
AbhishekA1509
previously approved these changes
Oct 24, 2025
There was a problem hiding this comment.
Approving on the notion that will re-visit after discussion with @uxarya-d regarding size variance, etc.
vivek-devtron
previously approved these changes
Oct 28, 2025
AbhishekA1509
approved these changes
Oct 28, 2025
vivek-devtron
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist