-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Illustration Component, Improve Table Component typings #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… render headerName
… GenericFilterEmptyState
…ib into feat/revamp-chart-store-details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Illustration component (with generation script and pre-commit hook), a PortalContainer component, enhances the UserIdentifier component, and refactors the Table components to use fully generic typings.
- Introduce IllustrationBase/Illustration and integrate into empty states, plus add
generate-illustration
script and hook - Add PortalContainer for dynamic portal mounting
- Convert Table utilities and types to generic
RowData
,FilterVariant
, andAdditionalProps
Reviewed Changes
Copilot reviewed 25 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/Shared/Components/index.ts | Export new Illustration and PortalContainer |
src/Shared/Components/Illustration/* | Add Illustration component, types, and auto-generated map |
scripts/generate-illustration.cjs | New script to build Illustration map |
.husky/pre-commit | Hook to run illustration generation on relevant changes |
src/Shared/Components/PortalContainer/PortalContainer.tsx | Create PortalContainer with useLayoutEffect |
src/Shared/Components/UserIdentifier/* | Add displayYouLabelForCurrentUser prop |
src/Shared/Components/Table/types.ts, utils.ts, * | Refactor Table to fully generic typings |
src/Common/EmptyState/GenericEmptyState.tsx | Use Illustration in empty states |
src/Shared/Components/Header/PageHeader.tsx | Guard rendering of headerName |
… update portal effect dependencies, and refactor internal table imports
…ib into feat/revamp-chart-store-details
5d9902d
…ib into feat/revamp-chart-store-details
…ib into feat/revamp-chart-store-details
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Checklist