Skip to content

feat: Illustration Component, Improve Table Component typings #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 15, 2025

Conversation

RohitRaj011
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 requested a review from Copilot July 10, 2025 12:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Illustration component (with generation script and pre-commit hook), a PortalContainer component, enhances the UserIdentifier component, and refactors the Table components to use fully generic typings.

  • Introduce IllustrationBase/Illustration and integrate into empty states, plus add generate-illustration script and hook
  • Add PortalContainer for dynamic portal mounting
  • Convert Table utilities and types to generic RowData, FilterVariant, and AdditionalProps

Reviewed Changes

Copilot reviewed 25 out of 30 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/Shared/Components/index.ts Export new Illustration and PortalContainer
src/Shared/Components/Illustration/* Add Illustration component, types, and auto-generated map
scripts/generate-illustration.cjs New script to build Illustration map
.husky/pre-commit Hook to run illustration generation on relevant changes
src/Shared/Components/PortalContainer/PortalContainer.tsx Create PortalContainer with useLayoutEffect
src/Shared/Components/UserIdentifier/* Add displayYouLabelForCurrentUser prop
src/Shared/Components/Table/types.ts, utils.ts, * Refactor Table to fully generic typings
src/Common/EmptyState/GenericEmptyState.tsx Use Illustration in empty states
src/Shared/Components/Header/PageHeader.tsx Guard rendering of headerName

AbhishekA1509
AbhishekA1509 previously approved these changes Jul 10, 2025
vivek-devtron
vivek-devtron previously approved these changes Jul 11, 2025
… update portal effect dependencies, and refactor internal table imports
@RohitRaj011 RohitRaj011 dismissed stale reviews from vivek-devtron and AbhishekA1509 via 5d9902d July 11, 2025 07:11
AbhishekA1509
AbhishekA1509 previously approved these changes Jul 11, 2025
@RohitRaj011 RohitRaj011 merged commit 3564a41 into develop Jul 15, 2025
6 checks passed
@RohitRaj011 RohitRaj011 deleted the feat/revamp-chart-store-details branch July 15, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants