feat: add tree view component #803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eView component structure with Divider
…nd update TreeView component for keyboard navigation support
…nd getUpdateItemsRefMap, and deprecate CollapsibleList component
…ctor divider styles
…r improved tooltip handling
AbhishekA1509
requested review from
vivek-devtron and
vikramdevtron
as code owners
There was a problem hiding this comment.
Pull Request Overview
Adds a new TreeView component with associated types, styling, and node rendering, while deprecating the older CollapsibleList and refactoring related components (ActionMenu and Tooltip) to integrate shared utilities.
- Introduce
TreeView(export, types, component, node content, SCSS) - Deprecate
CollapsibleListin favor ofTreeView - Refactor
TrailingItem,ActionMenuItem, andTooltipto share the new text-truncation hook
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Components/index.ts | Export the new TreeView |
| src/Shared/Components/TreeView/types.ts | Define TreeNode, TreeItem, TreeHeading, and TreeViewProps |
| src/Shared/Components/TreeView/index.ts | Re-export TreeView and its types |
| src/Shared/Components/TreeView/TreeViewNodeContent.tsx | Render node titles with optional truncation‐tooltip wrapping |
| src/Shared/Components/TreeView/TreeView.scss | Styles for tree items, dividers, and hover states |
| src/Shared/Components/TreeView/TreeView.component.tsx | Core TreeView logic (rendering, keyboard nav, animations) |
| src/Shared/Components/TrailingItem/types.ts | New TrailingItemType union |
| src/Shared/Components/TrailingItem/index.ts | Export TrailingItem |
| src/Shared/Components/TrailingItem/TrailingItem.component.tsx | Render the different trailing item types |
| src/Shared/Components/CollapsibleList/CollapsibleList.component.tsx | Mark CollapsibleList as deprecated |
| src/Shared/Components/ActionMenu/types.ts | Remove inline trailing-item types; import from TrailingItem |
| src/Shared/Components/ActionMenu/ActionMenuItem.tsx | Delegate trailing-item rendering to TrailingItem |
| src/Common/Tooltip/index.ts | Export the new useIsTextTruncated hook |
| src/Common/Tooltip/UseIsTextTruncated.ts | Extract text-overflow detection into a hook |
| src/Common/Tooltip/Tooltip.tsx | Simplify tooltip logic to use useIsTextTruncated |
… link interactions
…te and improve click handling
… threat count handling
…date props for better state management
…n-fe-common-lib into feat/tree-view
…common-lib into feat/tree-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new TreeView component with associated types, styling, and node rendering, while deprecating the older CollapsibleList and refactoring related components (ActionMenu and Tooltip) to integrate shared utilities.
TreeView(export, types, component, node content, SCSS)CollapsibleListin favor ofTreeViewTrailingItem,ActionMenuItem, andTooltipto share the new text-truncation hookType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist