Skip to content

fix: app details manifest scroll on change of resolution #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

AbhishekA1509
Copy link
Member

Description

Add root margin of 1px and increase sentinel height by 1px to overcome decimal dimensions

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

vivek-devtron
vivek-devtron previously approved these changes Jun 26, 2025
@AbhishekA1509 AbhishekA1509 changed the base branch from develop to main June 26, 2025 10:17
@AbhishekA1509 AbhishekA1509 dismissed vivek-devtron’s stale review June 26, 2025 10:17

The base branch was changed.

@AbhishekA1509 AbhishekA1509 merged commit faaa9f1 into main Jun 26, 2025
6 checks passed
@AbhishekA1509 AbhishekA1509 deleted the fix/use-sticky-decimal-width branch June 26, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants