Skip to content

Commit f41886e

Browse files
committed
chore: drop optional typing from tooltip props
1 parent c4192af commit f41886e

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/Common/Tooltip/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ type BaseTooltipProps =
3939
* If true, wrap with tippy irrespective of other options
4040
* @default true
4141
*/
42-
alwaysShowTippyOnHover?: boolean
42+
alwaysShowTippyOnHover: boolean
4343
/**
4444
* If true, use the common styling for shortcuts
4545
* @default undefined
@@ -62,7 +62,7 @@ type BaseTooltipProps =
6262
* If true, use the common styling for shortcuts
6363
* @default undefined
6464
*/
65-
shortcutKeyCombo?: {
65+
shortcutKeyCombo: {
6666
text: string
6767
combo: SupportedKeyboardKeysType[]
6868
}

src/Shared/Components/Button/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ export type ButtonProps = (
9797
// TODO: using some typing somersaults here, clean it up later
9898
tooltipProps:
9999
| Omit<TooltipProps, 'alwaysShowTippyOnHover' | 'showOnTruncate' | 'shortcutKeyCombo'>
100-
| Omit<TooltipProps, 'alwaysShowTippyOnHover' | 'showOnTruncate' | 'content'>
100+
| (Omit<TooltipProps, 'alwaysShowTippyOnHover' | 'showOnTruncate' | 'content'> &
101+
Required<Pick<TooltipProps, 'shortcutKeyCombo'>>)
101102
}
102103
| {
103104
showTooltip?: never

0 commit comments

Comments
 (0)