fix: js doc comments & logic in tooltip

Author: Elessar1802

src/Common/Tooltip/Tooltip.tsx

@@ -25,9 +25,11 @@ const Tooltip = ({
         }
     }
 
-    return (!showOnTruncate || !isTextTruncated) && !alwaysShowTippyOnHover && !shortcutKeyCombo ? (
-        cloneElement(child, { ...child.props, onMouseEnter: handleMouseEnterEvent })
-    ) : (
+    const showTooltipWhenShortcutKeyComboProvided =
+        !!shortcutKeyCombo && (alwaysShowTippyOnHover === undefined || alwaysShowTippyOnHover)
+    const showTooltipOnTruncate = showOnTruncate && isTextTruncated
+
+    return showTooltipOnTruncate || showTooltipWhenShortcutKeyComboProvided || alwaysShowTippyOnHover ? (
         <TippyJS
             arrow={false}
             placement="top"
@@ -39,6 +41,8 @@ const Tooltip = ({
         >
             {cloneElement(child, { ...child.props, onMouseEnter: handleMouseEnterEvent })}
         </TippyJS>
+    ) : (
+        cloneElement(child, { ...child.props, onMouseEnter: handleMouseEnterEvent })
     )
 }
 

src/Common/Tooltip/types.ts

@@ -24,7 +24,7 @@ type BaseTooltipProps =
           alwaysShowTippyOnHover?: never
           /**
            * If true, use the common styling for shortcuts
-           * @default false
+           * @default undefined
            */
           shortcutKeyCombo?: never
           content: TippyProps['content']
@@ -42,7 +42,7 @@ type BaseTooltipProps =
           alwaysShowTippyOnHover?: boolean
           /**
            * If true, use the common styling for shortcuts
-           * @default false
+           * @default undefined
            */
           shortcutKeyCombo?: never
           content: TippyProps['content']
@@ -60,13 +60,13 @@ type BaseTooltipProps =
           alwaysShowTippyOnHover?: boolean
           /**
            * If true, use the common styling for shortcuts
-           * @default true
+           * @default undefined
            */
-          content?: never
           shortcutKeyCombo?: {
               text: string
               combo: SupportedKeyboardKeysType[]
           }
+          content?: never
       }
 
 export type TooltipProps = BaseTooltipProps &

src/Shared/Components/CICDHistory/History.components.tsx

@@ -45,7 +45,6 @@ export const LogResizeButton = withShortcut(
         const { pathname } = useLocation()
 
         const toggleFullScreen = useCallback((): void => {
-            // NOTE: need to use ref due to the problem of stale function reference after registering the callback
             setFullScreenView(!fullScreenView)
         }, [fullScreenView])
 
@@ -101,7 +100,7 @@ export const LogResizeButton = withShortcut(
 
 export const Scroller = ({ scrollToTop, scrollToBottom, style }: ScrollerType): JSX.Element => (
     <div style={style} className="dc__element-scroller flex column top br-4">
-        <Tooltip content="Scroll to Top" placement="left">
+        <Tooltip alwaysShowTippyOnHover content="Scroll to Top" placement="left">
             <button
                 className="flex"
                 disabled={!scrollToTop}
@@ -112,7 +111,7 @@ export const Scroller = ({ scrollToTop, scrollToBottom, style }: ScrollerType):
                 <DropDownIcon className="rotate" style={{ ['--rotateBy' as any]: '180deg' }} />
             </button>
         </Tooltip>
-        <Tooltip content="Scroll to Bottom" placement="left">
+        <Tooltip alwaysShowTippyOnHover content="Scroll to Bottom" placement="left">
             <button
                 className="flex"
                 disabled={!scrollToBottom}