Skip to content

Commit c6446d5

Browse files
committed
fix: pass ciPipelineId instead of material id
1 parent eebf67b commit c6446d5

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "0.0.94-beta-4",
3+
"version": "0.0.95-beta-3",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Shared/Components/ArtifactInfoModal/ArtifactInfoModal.component.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,7 @@ const ArtifactInfoModal = ({
115115
type={HistoryComponentType.CI}
116116
imageReleaseTags={artifactInfo.imageReleaseTags}
117117
imageComment={artifactInfo.imageComment}
118-
// FIXME: This is a existing issue, we should be sending the pipeline id instead of the artifact id
119-
ciPipelineId={artifactInfo.materials[0].id}
118+
ciPipelineId={artifactInfo.ciPipelineId}
120119
artifactId={ciArtifactId}
121120
appReleaseTagNames={artifactInfo.appReleaseTags}
122121
tagsEditable={artifactInfo.tagsEditable}

src/Shared/Services/app.types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ interface ImageTaggingDataType
107107
}
108108

109109
export interface CIMaterialInfoDTO {
110+
ciPipelineId: number
110111
ciMaterials: CIMaterialDTO[]
111112
triggeredByEmail: string
112113
lastDeployedTime: string
@@ -128,6 +129,7 @@ export interface CIMaterialInfoType
128129
| 'environmentId'
129130
| 'environmentName'
130131
| 'image'
132+
| 'ciPipelineId'
131133
>,
132134
ImageTaggingDataType {
133135
materials: CIMaterialType[]

src/Shared/Services/utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ export const getParsedCIMaterialInfo = (ciMaterialData: CIMaterialInfoDTO): CIMa
4242
}))
4343

4444
return {
45+
ciPipelineId: ciMaterialData?.ciPipelineId,
4546
materials,
4647
triggeredByEmail: ciMaterialData?.triggeredByEmail || '',
4748
lastDeployedTime: handleUTCTime(ciMaterialData.lastDeployedTime, false),

0 commit comments

Comments
 (0)