refactor: remove redundant check with handleUTCTime

Author: eshankvaish

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.0.94-beta-3",
+    "version": "0.0.94-beta-4",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -23,7 +23,7 @@ import moment from 'moment'
 import { useLocation } from 'react-router-dom'
 import { toast } from 'react-toastify'
 import YAML from 'yaml'
-import { ERROR_EMPTY_SCREEN, SortingOrder, TOKEN_COOKIE_NAME, EXCLUDED_FALSY_VALUES, DISCORD_LINK, ZERO_TIME_STRING } from './Constants'
+import { ERROR_EMPTY_SCREEN, SortingOrder, EXCLUDED_FALSY_VALUES, DISCORD_LINK, ZERO_TIME_STRING } from './Constants'
 import { ServerErrors } from './ServerError'
 import { toastAccessDenied } from './ToastBody'
 import { AsyncOptions, AsyncState, UseSearchString } from './Types'
@@ -301,12 +301,10 @@ export function useForm(stateSchema, validationSchema = {}, callback) {
 export function handleUTCTime(ts: string, isRelativeTime = false) {
     let timestamp = ''
     try {
-        if (ts && ts.length) {
+        if (ts && ts.length && ts !== ZERO_TIME_STRING) {
             const date = moment(ts)
             if (isRelativeTime) {
-                if (ts !== ZERO_TIME_STRING) {
-                    timestamp = date.fromNow()
-                }
+                timestamp = date.fromNow()
             } else {
                 timestamp = date.format(DATE_TIME_FORMAT_STRING)
             }

src/Common/Helper.tsx

@@ -30,7 +30,7 @@ export const getParsedCIMaterialInfo = (ciMaterialData: CIMaterialInfoDTO): CIMa
             commitURL: mat.url ? createGitCommitUrl(mat.url, hist.Commit) : '',
             commit: hist.Commit || '',
             author: hist.Author || '',
-            date: hist.Date ? handleUTCTime(hist.Date, false) : '',
+            date: handleUTCTime(hist.Date, false),
             message: hist.Message || '',
             changes: hist.Changes || [],
             showChanges: index === 0,
@@ -44,7 +44,7 @@ export const getParsedCIMaterialInfo = (ciMaterialData: CIMaterialInfoDTO): CIMa
     return {
         materials,
         triggeredByEmail: ciMaterialData?.triggeredByEmail || '',
-        lastDeployedTime: ciMaterialData?.lastDeployedTime ? handleUTCTime(ciMaterialData.lastDeployedTime, false) : '',
+        lastDeployedTime: handleUTCTime(ciMaterialData.lastDeployedTime, false),
         environmentName: ciMaterialData?.environmentName || '',
         environmentId: ciMaterialData?.environmentId || 0,
         appId: ciMaterialData?.appId,