Skip to content

Commit 72b9c6c

Browse files
committed
chore: modification of feature description
1 parent cf1fbbb commit 72b9c6c

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "0.1.8",
3+
"version": "0.1.8-beta-19",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Common/Constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export const DOCUMENTATION = {
2626
APP_TAGS: `${DOCUMENTATION_HOME_PAGE}${DOCUMENTATION_VERSION}/usage/applications/create-application#tags`,
2727
APP_OVERVIEW_TAGS: `${DOCUMENTATION_HOME_PAGE}${DOCUMENTATION_VERSION}/usage/applications/overview#manage-tags`,
2828
BLOB_STORAGE: `${DOCUMENTATION_HOME_PAGE}${DOCUMENTATION_VERSION}/getting-started/install/installation-configuration#configuration-of-blob-storage`,
29+
GLOBAL_CONFIG_BUILD_INFRA: `${DOCUMENTATION_HOME_PAGE}${DOCUMENTATION_VERSION}/global-configurations/build-infra`,
2930
}
3031

3132
export const PATTERNS = {

src/Pages/GlobalConfigurations/BuildInfra/Descriptor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import { DescriptorProps } from './types'
18-
import { BreadCrumb } from '../../../Common'
18+
import { BreadCrumb, DOCUMENTATION } from '../../../Common'
1919
import { BUILD_INFRA_TEXT } from './constants'
2020
import { InfoIconTippy } from '../../../Shared'
2121

@@ -34,7 +34,7 @@ const Descriptor = ({
3434
infoText={tippyInfoText ?? BUILD_INFRA_TEXT.EDIT_DEFAULT_TOOLTIP}
3535
additionalContent={tippyAdditionalContent}
3636
heading={BUILD_INFRA_TEXT.HEADING}
37-
iconClassName="icon-dim-20"
37+
documentationLink={DOCUMENTATION.GLOBAL_CONFIG_BUILD_INFRA}
3838
/>
3939
</div>
4040

src/Shared/Components/FeatureDescription/FeatureTitleWithInfo.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ const FeatureTitleWithInfo = ({
3434
showInfoIconTippy,
3535
docLinkText = 'View Documentation',
3636
dataTestId = 'feature-title-with-info',
37+
additionalContent,
3738
}: DescriptorProps) => {
3839
const [showFeatureDescriptionModal, setShowFeatureDescriptionModal] = useState(false)
3940
const onClickInfoIcon = () => {
@@ -47,11 +48,14 @@ const FeatureTitleWithInfo = ({
4748
const renderTitle = () => {
4849
if (showInfoIconTippy) {
4950
return (
50-
<div className="flex left fs-16 cn-9 fw-6 mb-20 dc__gap-4" data-testid={dataTestId}>
51-
{title}
51+
<div className="flex left fs-16 cn-9 fw-6 dc__gap-4">
52+
<span data-testid={dataTestId} className="lh-32">
53+
{title}
54+
</span>
5255
<InfoIconTippy
5356
heading={title}
5457
infoText={renderDescriptionContent()}
58+
additionalContent={additionalContent}
5559
iconClassName={iconClassName}
5660
documentationLink={docLink}
5761
documentationLinkText={docLinkText}
@@ -60,7 +64,7 @@ const FeatureTitleWithInfo = ({
6064
</div>
6165
)
6266
}
63-
if (breadCrumbs) {
67+
if (breadCrumbs?.length > 0) {
6468
return (
6569
<div className="flexbox dc__align-items-center dc__gap-4">
6670
<BreadCrumb breadcrumbs={breadCrumbs} />
@@ -69,16 +73,15 @@ const FeatureTitleWithInfo = ({
6973
)
7074
}
7175

72-
return title
76+
return <span className="fs-16 fw-6 cn-9 lh-32">{title}</span>
7377
}
7478

7579
return (
7680
<>
7781
<div
78-
className={`feature-description flexbox dc__content-space dc__align-items-center w-100 ${additionalContainerClasses ?? ''}`}
82+
className={`feature-description flexbox dc__content-space dc__align-items-center ${additionalContainerClasses ?? ''}`}
7983
>
8084
{renderTitle()}
81-
8285
{children}
8386
</div>
8487
{showFeatureDescriptionModal && (

src/Shared/Components/FeatureDescription/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,5 @@ export interface DescriptorProps extends FeatureDescriptionModalProps {
3737
showInfoIconTippy?: boolean
3838
docLinkText?: string
3939
dataTestId?: string
40+
additionalContent?: ReactNode
4041
}

0 commit comments

Comments
 (0)