Skip to content

Commit cf1fbbb

Browse files
committed
feature description fix
1 parent 074465d commit cf1fbbb

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

src/Shared/Components/FeatureDescription/FeatureTitleWithInfo.tsx

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ const FeatureTitleWithInfo = ({
3232
docLink,
3333
SVGImage,
3434
showInfoIconTippy,
35+
docLinkText = 'View Documentation',
36+
dataTestId = 'feature-title-with-info',
3537
}: DescriptorProps) => {
3638
const [showFeatureDescriptionModal, setShowFeatureDescriptionModal] = useState(false)
3739
const onClickInfoIcon = () => {
@@ -43,26 +45,30 @@ const FeatureTitleWithInfo = ({
4345
}
4446

4547
const renderTitle = () => {
46-
if (breadCrumbs)
47-
<div className="flexbox dc__align-items-center dc__gap-4">
48-
<BreadCrumb breadcrumbs={breadCrumbs} />
49-
<ICHelpOutline className={`${iconClassName} icon-dim-20 cursor fcn-6`} onClick={onClickInfoIcon} />
50-
</div>
51-
else if (showInfoIconTippy) {
48+
if (showInfoIconTippy) {
5249
return (
53-
<div>
50+
<div className="flex left fs-16 cn-9 fw-6 mb-20 dc__gap-4" data-testid={dataTestId}>
5451
{title}
5552
<InfoIconTippy
5653
heading={title}
5754
infoText={renderDescriptionContent()}
5855
iconClassName={iconClassName}
5956
documentationLink={docLink}
60-
documentationLinkText={docLink}
57+
documentationLinkText={docLinkText}
6158
dataTestid="info-tippy-button"
6259
/>
6360
</div>
6461
)
6562
}
63+
if (breadCrumbs) {
64+
return (
65+
<div className="flexbox dc__align-items-center dc__gap-4">
66+
<BreadCrumb breadcrumbs={breadCrumbs} />
67+
<ICHelpOutline className={`${iconClassName} icon-dim-20 cursor fcn-6`} onClick={onClickInfoIcon} />
68+
</div>
69+
)
70+
}
71+
6672
return title
6773
}
6874

src/Shared/Components/FeatureDescription/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,6 @@ export interface DescriptorProps extends FeatureDescriptionModalProps {
3535
iconClassName?: string
3636
children?: React.ReactNode
3737
showInfoIconTippy?: boolean
38+
docLinkText?: string
39+
dataTestId?: string
3840
}

0 commit comments

Comments
 (0)