Skip to content

Commit 53de3f0

Browse files
committed
feat: add AppStatusContent component with styling for improved layout in AppStatusModal
1 parent b31ee60 commit 53de3f0

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

src/Shared/Components/AppStatusModal/AppStatusModal.scss renamed to src/Shared/Components/AppStatusModal/AppStatusContent.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.app-status-modal {
1+
.app-status-content {
22
.app-status-content {
33
&__row {
44
grid-template-columns: 150px 200px 100px auto;

src/Shared/Components/AppStatusModal/AppStatusContent.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import { Icon } from '../Icon'
1111
import { AppStatusContentProps } from './types'
1212
import { getFlattenedNodesFromAppDetails, getResourceKey } from './utils'
1313

14+
import './AppStatusContent.scss'
15+
1416
const APP_STATUS_ROWS_BASE_CLASS = 'px-16 py-8 dc__grid dc__column-gap-16 app-status-content__row'
1517

1618
const AppStatusContent = ({
@@ -119,7 +121,7 @@ const AppStatusContent = ({
119121
}
120122

121123
return (
122-
<div className={`flexbox-col ${isCardLayout ? 'br-6 border__primary' : ''}`}>
124+
<div className={`flexbox-col app-status-content ${isCardLayout ? 'br-6 border__primary' : ''}`}>
123125
{!!flattenedNodes.length && (
124126
<div className="p-12">
125127
<StatusFilterButtonComponent

src/Shared/Components/AppStatusModal/AppStatusModal.component.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ import { AppStatusBody } from './AppStatusBody'
1717
import { getAppDetails } from './service'
1818
import { AppStatusModalProps } from './types'
1919

20-
import './AppStatusModal.scss'
21-
2220
const AppStatusModal = ({
2321
title,
2422
handleClose,

src/Shared/Components/CICDHistory/DeploymentStatusDetailRow.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ export const DeploymentStatusDetailRow = ({
155155
</div>
156156
)}
157157
<div>
158-
{/* TODO: Test */}
159158
<AppStatusContent appDetails={appDetails} filterHealthyNodes isCardLayout={false} />
160159
</div>
161160
</div>

src/Shared/Components/Error/ErrorBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ import { ErrorBarType } from './types'
2323
import { getIsImagePullBackOff, renderErrorHeaderMessage } from './utils'
2424

2525
const ErrorBar = ({ appDetails }: ErrorBarType) => {
26-
const isImagePullBackOff = getIsImagePullBackOff(appDetails)
27-
2826
if (
2927
!appDetails ||
3028
appDetails.appType !== AppType.DEVTRON_APP ||
@@ -35,6 +33,8 @@ const ErrorBar = ({ appDetails }: ErrorBarType) => {
3533
return null
3634
}
3735

36+
const isImagePullBackOff = getIsImagePullBackOff(appDetails)
37+
3838
return (
3939
isImagePullBackOff && (
4040
<div className="er-2 bw-1 br-4 m-20 fs-13">

0 commit comments

Comments
 (0)