Skip to content

Commit b31ee60

Browse files
committed
refactor: remove CONFIG_DRIFT constant, update ConfigDriftModalProps to require envId, and enhance styling in AppStatusModal and DeploymentStatusDetailRow components
1 parent c1493b2 commit b31ee60

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/Common/Constants.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ export const URLS = {
8585
COMPARE_CLUSTERS: '/compare-clusters',
8686
APP_CONFIG: 'edit',
8787
GLOBAL_CONFIG: '/global-config',
88-
CONFIG_DRIFT: 'config-drift',
8988
GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP,
9089
GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP_CREATE: `${GLOBAL_CONFIG_TEMPLATES_DEVTRON_APP}/create`,
9190
// NOTE: using appId since we are re-using AppConfig component

src/Shared/Components/AppStatusModal/AppStatusContent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const AppStatusContent = ({
8989
<span className="dc__word-break">{nodeDetails.name}</span>
9090

9191
<div
92-
className={`app-summary__status-name f-${getNodeStatus(nodeDetails)?.toLowerCase() || ''} dc__first-letter-capitalize--imp`}
92+
className={`app-summary__status-name f-${getNodeStatus(nodeDetails)?.toLowerCase() || ''} dc__first-letter-capitalize--imp fs-13 fw-4 lh-20`}
9393
>
9494
{getNodeStatus(nodeDetails)}
9595
</div>

src/Shared/Components/CICDHistory/DeploymentStatusDetailRow.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,9 @@ export const DeploymentStatusDetailRow = ({
183183
<span className="ml-12 mr-12 fs-13">
184184
<span data-testid="deployment-status-step-name">{statusBreakDownType.displayText}</span>
185185
{statusBreakDownType.displaySubText && (
186-
<span className={`ml-12 f-${statusBreakDownType.icon || 'waiting'}`}>
186+
<span
187+
className={`ml-12 app-summary__status-name f-${statusBreakDownType.icon || 'waiting'}`}
188+
>
187189
{statusBreakDownType.displaySubText}
188190
</span>
189191
)}

src/Shared/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,9 +247,9 @@ export interface AppDetails {
247247
FluxAppStatusDetail?: FluxAppStatusDetail
248248
}
249249

250-
export interface ConfigDriftModalProps extends Pick<AppDetails, 'appId'> {
250+
export interface ConfigDriftModalProps extends Required<Pick<AppDetails, 'appId'>> {
251+
envId: number
251252
handleCloseModal?: () => void
252-
envId?: number
253253
}
254254

255255
export enum RegistryType {

0 commit comments

Comments
 (0)