-
Notifications
You must be signed in to change notification settings - Fork 2
feat: wrapped routes & plausible script #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add ci for migration * add 'npm run format' command to all three packages * remove all instances of any type being used in migration * remove logger in migration service
* UNI-304: changed layout screen height * UNI-304: course titles set to not break --------- Co-authored-by: Bob Chen <83627389+3bobchen@users.noreply.github.com> Co-authored-by: Jared L <48422312+lhjt@users.noreply.github.com> Co-authored-by: Dylan W <119717655+dylanwz@users.noreply.github.com> Co-authored-by: 3syth <120223314+3syth@users.noreply.github.com> Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> Co-authored-by: ur-ja <67295135+ur-ja@users.noreply.github.com> Co-authored-by: Maximilian Falco Widjaya <97402501+maximilianfalco@users.noreply.github.com> Co-authored-by: dylan <birds@DylanW-PC> Co-authored-by: Dylan <inutuzumab@gmail.com>
* filter modal and tried to implement the api * deleted file * made the filter modal look nicer * rearranged buttons and repsonsiveness of it * finished the frontend of the filter button * chore: 271 (added sitemap) & 287 (setup linters) (#294) * Chore/uni 271 sitemap xml (#293) * finished code to generate the sitemap (using temp data currently) * fixed branch name * added api to get a list of all courses and updated swagger.json to include this route * changed name of all courses api * fixed the inconsistent names when logging info on /courses/all * generated sitemap in both root and frontend folder * removed sitemap.ts from root (was moved to frontend so we could generate the xml) * moved sitemap to public folder --------- Co-authored-by: lightAndTangy <a.xinyuetang@gmail.com> * chore: UNI-287 Set up linter and formatter (#291) * install prettier and add configs, uninstall eslint-plugin-prettier for backend * move eslint to dev dependencies in frontend * install and configure prettier and eslint-config-prettier * install eslint for migration package * install and configure prettier for migration package * add lint command to package.json in migration --------- Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * help fix pls xD * attempt to make backend work * save curr progress * query works with hardcoded terms * working draft * trying to fix sql query (remove unsafe) * combined search and filters together * deleted search functions * commented out all the search functions * fixed canberra bug * merge linting gh actions (#303) chore: UNI-292 linting GitHub actions (#295) * add ci for migration * add 'npm run format' command to all three packages * remove all instances of any type being used in migration * remove logger in migration service Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * uncommented search and fixed responsiveness and added semesters * removed console logs * fixed any type * UNI-304: changed layout screen height * UNI-304: course titles set to not break * working filter function * added dark mode * added hover over buttons * fixed type * fix filter object type * bugfix: load more courses & login button missing (#307) * Bugfix/uni 304 load courses (#305) * UNI-304: changed layout screen height * UNI-304: course titles set to not break --------- Co-authored-by: dylan <birds@DylanW-PC> Co-authored-by: Dylan <inutuzumab@gmail.com> --------- * fixed not offered issue ---------
This reverts commit 7547be2.
* feat: update devsoc branding references (#260) * chore(landing): update landing meta description * Update README.md * Merge Develop To Main (#289) * fix: added schema (#285) Added Offers and hasCourseInstance schema to the metadata of courses Schema Docs: https://developers.google.com/search/docs/appearance/structured-data/course-info#structured-data-type-definitions * fix: UNI-278 add else branch in getInitialDisplayCourses to reset search bar state (#284) --------- Co-authored-by: 3syth <120223314+3syth@users.noreply.github.com> Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * Feature/uni 274 sponsor logos (#283) * chore(logos): add jane street and tiktok svgs * feat(sponsors): add sponsors to hero section * feat(heading): add sponsored by heading and fix padding * fix(height): fix height on smaller screens * fix(quotes): replace single quotes with double quotes * fix: truncated reviews and t&c (#290) * fix: added schema (#285) Added Offers and hasCourseInstance schema to the metadata of courses Schema Docs: https://developers.google.com/search/docs/appearance/structured-data/course-info#structured-data-type-definitions * fix: UNI-278 add else branch in getInitialDisplayCourses to reset search bar state (#284) * chore/uni-270-desc-and-tnc-fix (#279) * feat: update devsoc branding references (#260) * chore(landing): update landing meta description * Update README.md * fixed truncated descriptions * deleted some useless code * Fixed some eedge cases and added comments * reverted some old changes regarding fetching reviews * Merge Develop To Main (#289) * fix: added schema (#285) Added Offers and hasCourseInstance schema to the metadata of courses Schema Docs: https://developers.google.com/search/docs/appearance/structured-data/course-info#structured-data-type-definitions * fix: UNI-278 add else branch in getInitialDisplayCourses to reset search bar state (#284) --------- Co-authored-by: 3syth <120223314+3syth@users.noreply.github.com> Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * Fixed bug of review card showing another review's description * removed inline from review desc --------- Co-authored-by: Bob Chen <83627389+3bobchen@users.noreply.github.com> Co-authored-by: Jared L <48422312+lhjt@users.noreply.github.com> Co-authored-by: Dylan W <119717655+dylanwz@users.noreply.github.com> Co-authored-by: eaglethrost <dimazanugrah12@gmail.com> Co-authored-by: Dimas Putra Anugerah <63914983+eaglethrost@users.noreply.github.com> Co-authored-by: 3syth <120223314+3syth@users.noreply.github.com> Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> --------- Co-authored-by: 3syth <120223314+3syth@users.noreply.github.com> Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> Co-authored-by: Maximilian Falco Widjaya <97402501+maximilianfalco@users.noreply.github.com> Co-authored-by: Bob Chen <83627389+3bobchen@users.noreply.github.com> Co-authored-by: Jared L <48422312+lhjt@users.noreply.github.com> Co-authored-by: Dylan W <119717655+dylanwz@users.noreply.github.com> * chore: 271 (added sitemap) & 287 (setup linters) (#294) * Chore/uni 271 sitemap xml (#293) * finished code to generate the sitemap (using temp data currently) * fixed branch name * added api to get a list of all courses and updated swagger.json to include this route * changed name of all courses api * fixed the inconsistent names when logging info on /courses/all * generated sitemap in both root and frontend folder * removed sitemap.ts from root (was moved to frontend so we could generate the xml) * moved sitemap to public folder --------- Co-authored-by: lightAndTangy <a.xinyuetang@gmail.com> * chore: UNI-287 Set up linter and formatter (#291) * install prettier and add configs, uninstall eslint-plugin-prettier for backend * move eslint to dev dependencies in frontend * install and configure prettier and eslint-config-prettier * install eslint for migration package * install and configure prettier for migration package * add lint command to package.json in migration --------- Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * merge linting gh actions (#303) chore: UNI-292 linting GitHub actions (#295) * add ci for migration * add 'npm run format' command to all three packages * remove all instances of any type being used in migration * remove logger in migration service Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * bugfix: load more courses & login button missing (#307) * Bugfix/uni 304 load courses (#305) * UNI-304: changed layout screen height * UNI-304: course titles set to not break --------- Co-authored-by: dylan <birds@DylanW-PC> Co-authored-by: Dylan <inutuzumab@gmail.com> --------- * feature/uni 261 filter button (#308) * Feature/uni 261 filter button (#306) * filter modal and tried to implement the api * deleted file * made the filter modal look nicer * rearranged buttons and repsonsiveness of it * finished the frontend of the filter button --------- * help fix pls xD * attempt to make backend work * save curr progress * query works with hardcoded terms * working draft * trying to fix sql query (remove unsafe) * combined search and filters together * deleted search functions * commented out all the search functions * fixed canberra bug * merge linting gh actions (#303) chore: UNI-292 linting GitHub actions (#295) * add ci for migration * add 'npm run format' command to all three packages * remove all instances of any type being used in migration * remove logger in migration service Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> * uncommented search and fixed responsiveness and added semesters * removed console logs * fixed any type * UNI-304: changed layout screen height * UNI-304: course titles set to not break * working filter function * added dark mode * added hover over buttons * fixed type * fix filter object type * bugfix: load more courses & login button missing (#307) * Bugfix/uni 304 load courses (#305) * UNI-304: changed layout screen height * UNI-304: course titles set to not break --------- Co-authored-by: dylan <birds@DylanW-PC> Co-authored-by: Dylan <inutuzumab@gmail.com> --------- * fixed not offered issue --------- * fix: filter buttons too tall in safari * Revert "fix: filter buttons too tall in safari" This reverts commit 7547be2. * fix: fixed filter buttons too tall in safari --------- * feat(snippet): add plausible snippet to the head * fix(domain): modify domain to staging * fix(quotes): revert to original style --------- Co-authored-by: Bob Chen <83627389+3bobchen@users.noreply.github.com> Co-authored-by: Jared L <48422312+lhjt@users.noreply.github.com> Co-authored-by: Dylan W <119717655+dylanwz@users.noreply.github.com> Co-authored-by: eaglethrost <dimazanugrah12@gmail.com> Co-authored-by: Dimas Putra Anugerah <63914983+eaglethrost@users.noreply.github.com> Co-authored-by: 3syth <120223314+3syth@users.noreply.github.com> Co-authored-by: Adrian Balbalosa <87012111+adrianbalbs@users.noreply.github.com> Co-authored-by: Maximilian Falco Widjaya <97402501+maximilianfalco@users.noreply.github.com> Co-authored-by: dylan <birds@DylanW-PC>
* create repository and service functions to find review with the most votes * write tests for getMostLikedReview * add get endpoint for most liked review * use cardinality instead of array_length for most liked * rename getMostLikedReview to getMostLiked, added caching * add query to find course with highest enjoyability * create stub fn and test for getHighestEnjoyability * create getHighestEnjoyment method * changed mostLiked endpoint to use kebab-case * make nulls be considered last for highest enjoyability * create endpoint to find highest-enjoyability * write query to get course with highest usefulness * write service method and test for highest usefulness * add endpoint to get highest usefulness course * write query for manageability * write method for course manageability and tests * add endpoint for highest manageability * implement query to find highest rated course in term * write method and tests for highest rated per term * implement endpoint for highest rated per term * add sort on review count for highest rated course per term * add redis caching for obtaining highest rated course * add second sort for review count on other queries * delete unused review id types * remove ReviewId import * add unit test for no course in db * remove comment * remove redundant ReviewIdSchema import in review.repository * refactor highest attribute query into one function * refactor highest rated attribute course service functions to be one fn * refactor course controller routes for highest rated attribute * forgot to change logger string for highest-attribute * remove unused imports * prefix wrapped routes with /wrapped * prefix logger messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.