Skip to content

fix(lp): changed the color of text from white to black on lightmode #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

fix(lp): changed the color of text from white to black on lightmode #1213

merged 1 commit into from
Apr 18, 2025

Conversation

jcongc
Copy link

@jcongc jcongc commented Apr 18, 2025 •
edited
Loading

  • Previously could not see text on the landing page and header if on light mode
  • Changed the text color to be white if dark mode, and otherwise it should be black

image

  • Currently cannot see white text on lightmode

@jcongc jcongc requested a review from a team as a code owner April 18, 2025 06:30
matthew-lim-matthew-lim
matthew-lim-matthew-lim approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@matthew-lim-matthew-lim matthew-lim-matthew-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice work Jason. PS. the 2 checks for CI fail just because of an outdated CI setup on 331 that I fixed on dev branch. I can fix that

@matthew-lim-matthew-lim matthew-lim-matthew-lim merged commit c6c4a0c into 331-staging Apr 18, 2025
9 of 11 checks passed
@matthew-lim-matthew-lim matthew-lim-matthew-lim deleted the fix/lp/331-change-lp-text-color branch April 18, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lim-matthew-lim matthew-lim-matthew-lim matthew-lim-matthew-lim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcongc @matthew-lim-matthew-lim