updating tests to support all db types #495
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Updating Tests to Support All DB Types
Motivation
This pull request aims to enhance our testing framework by adding support for multiple database types, including SQLite, PostgreSQL, MySQL, MS SQL Server, and Oracle. The motivation behind this change is to ensure that our application is robust and performs consistently across various database environments, which is critical for our users who may choose different database systems based on their needs.
Key Changes
CI Configuration Update: The CI configuration has been updated to include a matrix strategy that tests against all the specified database types. This ensures that every commit and pull request is validated against the full range of supported databases.
Service Configuration for Databases: Each database type now has its own service configuration, allowing the CI environment to spin up the necessary database instances automatically. This includes health checks to ensure that the databases are ready before tests are run.
Dynamic Database URL Setup: The
DATABASE_URL
environment variable is set dynamically based on the selected database type, making it straightforward to connect to the appropriate database during tests.Test Adjustments: Adjustments have been made in the test suite to ensure compatibility with the different database systems, including handling specific configurations and parameters unique to each database type.
Benefits
Overall, this enhancement significantly strengthens our testing framework and improves the quality of our codebase.