Adding Database Disconnect #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Adding Database Disconnect
This pull request introduces a new asynchronous method,
disconnect
, to theasync_database.py
module, allowing for a clean and efficient disconnection from the database engine. This change is crucial for resource management, ensuring that database connections are properly closed when they are no longer needed, which can help prevent resource leaks and improve the overall stability of the application.Motivation:
Changes Made:
disconnect
method inasync_database.py
, which disposes of the database engine and logs the disconnection process.lifespan
context manager infastapi_example.py
to call the new disconnect method during application shutdown, ensuring that resources are released appropriately.Impact on the Project:
This change significantly enhances the project's database handling capabilities, contributing to better resource management and application performance. It aligns with best practices for asynchronous programming in FastAPI and promotes a more maintainable codebase.