-
Notifications
You must be signed in to change notification settings - Fork 0
Adding Resiliency to Logging Config #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug Fixes
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Adding Resiliency to Logging Config
This pull request introduces enhancements to the logging configuration module, significantly improving the robustness and usability of the logging system in our project. The motivation behind these changes is to ensure that logging remains reliable even in the face of potential issues, such as file system errors or interruptions during write operations.
Key Changes:
Resilient File Sink Implementation:
ResilientFileSink
class that retries log write operations upon failure. This is crucial for applications that require persistent logging, as it minimizes the risk of losing log entries due to transient errors.Enhanced Logging Configuration:
config_log
function now includes options for enabling or disabling the interception of standard logging and whether to use a file sink. This provides users with greater flexibility in configuring their logging behavior.Detailed Logging Options:
Version Update:
0.13.1
to reflect these enhancements.Impact on the Project:
These changes significantly improve the reliability of our logging system, which is a critical component for monitoring and debugging applications. By ensuring that logs are written consistently and accurately, we enhance the overall observability of the system, making it easier to diagnose issues and track application behavior over time.
In summary, this pull request not only enhances the functionality of our logging configuration but also aligns with best practices for resilient software design, ultimately contributing to a more robust application.