-
Notifications
You must be signed in to change notification settings - Fork 93
[WIP]fix: Add -mod=readonly
to ginkgo version fetch and go install
#623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP]fix: Add -mod=readonly
to ginkgo version fetch and go install
#623
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ignoring EC failure as the fix is blocked by this issue. |
Hmmm.. this might need further investigation into what is going on, this change did fix this problem in my local testing using the openshift release image 😕 I'll put this PR in WIP for now. |
Can reproduce error in latest fail under a local pull of the runner image:
When I add
|
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
-mod=readonly
to ginkgo version fetch-mod=readonly
to ginkgo version fetch and go install
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description of Changes
Fixes the ginkgo not found and ginkgo version fetch failures by adding
-mod=readonly
to thego list
part of the ginkgo version fetch statement and thego install
command.Related Issue(s)
resolves devfile/api#1737
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.