Skip to content

[WIP]fix: Add -mod=readonly to ginkgo version fetch and go install #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jul 14, 2025

Description of Changes

Fixes the ginkgo not found and ginkgo version fetch failures by adding -mod=readonly to the go list part of the ginkgo version fetch statement and the go install command.

Related Issue(s)

resolves devfile/api#1737

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron requested a review from a team as a code owner July 14, 2025 19:12
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk July 14, 2025 19:13
Copy link

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

Ignoring EC failure as the fix is blocked by this issue.

@michael-valdron
Copy link
Member Author

Hmmm.. this might need further investigation into what is going on, this change did fix this problem in my local testing using the openshift release image 😕

I'll put this PR in WIP for now.

@michael-valdron
Copy link
Member Author

Can reproduce error in latest fail under a local pull of the runner image:

+ go install github.com/onsi/ginkgo/v2/ginkgo@v2.19.0
go: github.com/onsi/ginkgo/v2/ginkgo@v2.19.0: cannot query module due to -mod=vendor

When I add -mod=readonly also to go install the problem is resolved:

+ go install -mod=readonly github.com/onsi/ginkgo/v2/ginkgo@v2.19.0
go: downloading github.com/onsi/ginkgo/v2 v2.19.0
go: downloading golang.org/x/tools v0.21.0
go: downloading github.com/go-task/slim-sprig/v3 v3.0.0
go: downloading github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review July 15, 2025 05:35
@openshift-ci openshift-ci bot requested a review from Jdubrick July 15, 2025 05:35
@michael-valdron michael-valdron changed the title fix: Add -mod=readonly to ginkgo version fetch [WIP]fix: Add -mod=readonly to ginkgo version fetch and go install Jul 15, 2025
Copy link

openshift-ci bot commented Jul 15, 2025

@michael-valdron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.16-registry-test fca92ac link true /test v4.16-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community devfile registry integration testing is failing due to missing ginkgo
1 participant