Adds Dockerfile for easy setup #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a Dockerfile for containerizing the application. Updates the README with instructions on how to build and run the application in a Docker container.
j08lue
requested changes
May 7, 2025
There was a problem hiding this comment.
I think we should build the app at image build time because a container that builds the app at runtime is not very useful, I think.
We would not ship the image, just include the Dockerfile, so people can build the image themselves, baking in their own config. It's not worth a lot since there is barely any logic, but perhaps a nice reference for people.
Here is a PR that makes this change, pls feel free to merge into yours:
Build app at image build time
Introduces environment variable configuration for the client application. Adds an `.env.example` file to serve as a template for configuration. Moves environment variable loading and checking to a dedicated module for better organization and reusability. Modifies build and server tasks to utilize the new environment variable handling. Updates the README to include instructions on configuring the environment. Fix #43
|
@j08lue Included the improvement to env variables loading |
j08lue
approved these changes
May 8, 2025
4 tasks
danielfdsilva
force-pushed
the
feature/docker
branch
from
7df4899 to
7aa35b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a Dockerfile for containerizing the application.
Updates the README with instructions on how to build and run the application in a Docker container.
Closes #41
Closes #43