-
Notifications
You must be signed in to change notification settings - Fork 2
Prefetch reader #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Prefetch reader #18
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,6 +114,44 @@ impl AsyncFileReader for ObjectReader { | |
} | ||
} | ||
|
||
pub struct PrefetchReader { | ||
reader: Box<dyn AsyncFileReader>, | ||
buffer: Bytes, | ||
} | ||
|
||
impl PrefetchReader { | ||
pub async fn new(mut reader: Box<dyn AsyncFileReader>, prefetch: u64) -> Result<Self> { | ||
let buffer = reader.get_bytes(0..prefetch).await?; | ||
Ok(Self { reader, buffer }) | ||
} | ||
} | ||
|
||
impl AsyncFileReader for PrefetchReader { | ||
fn get_bytes(&mut self, range: Range<u64>) -> BoxFuture<'_, Result<Bytes>> { | ||
if range.start < self.buffer.len() as _ { | ||
if range.end < self.buffer.len() as _ { | ||
let usize_range = range.start as usize..range.end as usize; | ||
let result = self.buffer.slice(usize_range); | ||
async { Ok(result) }.boxed() | ||
Comment on lines
+133
to
+135
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then if the start and end of the requested range are fully within the existing cached buffer, we return that slice. |
||
} else { | ||
// TODO: reuse partial internal buffer | ||
self.reader.get_bytes(range) | ||
} | ||
} else { | ||
self.reader.get_bytes(range) | ||
} | ||
} | ||
|
||
fn get_byte_ranges(&mut self, ranges: Vec<Range<u64>>) -> BoxFuture<'_, Result<Vec<Bytes>>> | ||
where | ||
Self: Send, | ||
{ | ||
// In practice, get_byte_ranges is only used for fetching tiles, which are unlikely to | ||
// overlap a metadata prefetch. | ||
self.reader.get_byte_ranges(ranges) | ||
} | ||
} | ||
|
||
#[derive(Debug, Clone, Copy, Default)] | ||
pub enum Endianness { | ||
#[default] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We pre-fetch this prefix of the file when "opening" this reader layer