Skip to content

Move endianness check into AsyncCursor constructor #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

kylebarron
Copy link
Member

This should avoid accidentally constructing an AsyncCursor with wrong endianness.

Previously, we constructed the cursor with AsyncCursor::new and then had to remember to call set_endianness. Now we move that logic into the try_open_tiff constructor and make new take an endianness explicitly.

@kylebarron kylebarron merged commit 6c92598 into main Feb 22, 2025
1 check passed
@kylebarron kylebarron deleted the kyle/async-cursor-init branch February 22, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant