Skip to content

Support empty password when using local mysql for test #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zhangzhw8
Copy link

  1. Support empty password with warning log when using local mysql for test
  2. Fix some flake8 problem by the way.

@designcomputer
Copy link
Owner

@zhangzhw8 Thank you for your contribution! While the addition of support for empty passwords in local MySQL testing could be convenient, it raises some concerns:

  1. Security Risks: Allowing empty passwords, even in a testing environment, could lead to accidental configurations being deployed in production, which poses a significant security vulnerability.
  2. Best Practices: This change might encourage practices that deviate from secure coding standards, potentially impacting the reliability of the system.
  3. Safeguards: It is unclear from the current implementation whether there are adequate safeguards to prevent this feature from being used outside of a testing context.

We are currently reviewing the potential risks versus the benefits of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants