Skip to content

Fix/get action to work #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Fix/get action to work #1

merged 3 commits into from
Sep 14, 2024

Conversation

derrix060
Copy link
Owner

No description provided.

@derrix060 derrix060 force-pushed the fix/get-action-to-work branch 13 times, most recently from 627e454 to 154d328 Compare September 14, 2024 10:01
@derrix060 derrix060 marked this pull request as ready for review September 14, 2024 10:03
@derrix060 derrix060 enabled auto-merge (rebase) September 14, 2024 10:04
@derrix060 derrix060 disabled auto-merge September 14, 2024 10:18
@derrix060 derrix060 force-pushed the fix/get-action-to-work branch from ad1cbb7 to a8474c8 Compare September 14, 2024 10:23
- Update action.yml to install cargo-msrv
- Fix how to get result from function
- Fix comparison by sorting in descending version order
- use echo instead of return for function
- get only the msrv-complete log from msrv
- use newer way to set an output
- log cargo-msrv output on failure
@derrix060 derrix060 force-pushed the fix/get-action-to-work branch from a8474c8 to e5c247c Compare September 14, 2024 10:25
This commit adds a new GitHub Actions workflow file, `ci.yml`,
which is responsible for running tests and checks on the main
branch and pull requests. The workflow is triggered on pull
requests targeting the main branch and can also be manually
triggered using the workflow_dispatch event.

The workflow consists of a single job, `find-smallest-rust`,
which runs on the latest version of Ubuntu. It performs the
following steps:
1. Checks out the repository using the `actions/checkout` action.
2. Checks out the `NethermindEth/juno` repository using the `actions/checkout` action and stores it in the `juno` directory.
3. Uses a custom action, `./itself/action.yml`, to find the smallest supported Rust version in the `juno/core/rust/`, `juno/vm/rust/`, and `juno/starknet/rust/` directories.

This workflow is designed to ensure that the codebase is
compatible with the minimum supported Rust version specified
in the `juno` repository.
@derrix060 derrix060 force-pushed the fix/get-action-to-work branch from e5c247c to 994d31c Compare September 14, 2024 10:26
@derrix060 derrix060 enabled auto-merge (rebase) September 14, 2024 10:28
@derrix060 derrix060 merged commit 2654b64 into main Sep 14, 2024
1 check passed
@derrix060 derrix060 deleted the fix/get-action-to-work branch September 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant