Further performance improvement proposal #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thanks, will look at it |
dergraf
reviewed
Dec 23, 2022
| return enif_make_badarg(env); | ||
| } | ||
| msc_rules_add_file(ctx->rules, (const char *)conf_file.data, &modsec_error); | ||
| msc_rules_add_file(rules, (const char *)conf_file.data, &modsec_error); |
Owner
There was a problem hiding this comment.
I wonder how reloading the rules or rather "replacing" the rules would work (rule update scenario). Have you though about it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rather bold simplification 😅. With passing tests 💪 .
Please consider this as a proposal.
I don't have a stress test setup, so if you get a chance to take it for a spin first (without merging) I would be curious to know how that works out.
Lastly, I still believe
enif_make_list_cellis a performance bottleneck! Sinceenvis in task context, perhaps streaming logs back immediately as erlang messages as and when they are produced might help. I wanted to give that a shot too but ran out of time 😞.