Skip to content

More intl. titles #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More intl. titles #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions nameparser/config/titles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@
'designer',
'detective',
'developer',
'dhr',
'diplomat',
'dir',
'director',
Expand Down Expand Up @@ -289,7 +290,13 @@
'foreign',
'forester',
'founder',
'fr',
'frau',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too familiar with German, but we just need to make sure that things in the titles constant are not things that might conceivably be a first name. This would mean that anyone named Frau would have their name parsed incorrectly. When there's two right ways to parse a name, the parser prefers to parse first and last name correctly over titles. Is "Frau" ever used as a first name?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not be able to think of "Frau" being used as a first name. "Frauke" is a first name, but "Frau" used to be a sign for nobility (as in "Freifrau") in the middle ages, and trickled down to a common denominator of sex/gender lateron. So it would be common to be used in appellative function or when addressing a female person in writing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I these are all very legitimate and common titles.
Maybe a bit philosophical at this stage, but ... People can be named the strangest things, so requiring the categories to be distinct is unrealistic in my opinion. I think the role of this library should be to make a "best guess", probably not ONLY based on whether it matches these data points. The amount words and categories of there are also very important factors that the library could take into account (in some future version). For example, I definitely know of people named Prince or Sheikh as their first names. So if we come across such words, we probably need to look at the context to make a best guess about what it means. Same thing applies to the prefixes like "Van" which are very common prefixes but also first names and possibly (unlikely IMO) middle names.

'friar',
'fru',
'frou',
'frk',
'frøken',
'gaf',
'gen',
'general',
Expand All @@ -312,6 +319,10 @@
'heiress',
'her',
'hereditary',
'heren',
'herr',
'herren',
'herrn',
'high',
'highness',
'his',
Expand All @@ -323,6 +334,7 @@
'honorable',
'honourable',
'host',
'hr',
'illustrator',
'imam',
'industrialist',
Expand Down Expand Up @@ -397,6 +409,9 @@
'memoirist',
'merchant',
'metropolitan',
'mevr',
'mevrouw',
'mevrouwe',
'mg',
'mgr',
'mgysgt',
Expand All @@ -412,6 +427,8 @@
'model',
'monk',
'monsignor',
'monsieur',
'monseigneur',
'most',
'mountaineer',
'mpco-cg',
Expand All @@ -427,6 +444,7 @@
'musician',
'musicologist',
'mystery',
'mx',
'nanny',
'narrator',
'national',
Expand Down Expand Up @@ -536,6 +554,15 @@
'security',
'seigneur',
'senator',
'senhor',
'senhora',
'senhorita',
'senhoro',
'señor',
'señora',
'señores',
'señorita',
'señoritas',
'senior',
'senior-judge',
'sergeant',
Expand All @@ -549,6 +576,10 @@
'sheikh',
'sheriff',
'siddha',
'signor',
'signora',
'signore',
'signorina',
'singer',
'singer-songwriter',
'sma',
Expand All @@ -566,7 +597,9 @@
'special',
'sr',
'sra',
'sres',
'srta',
'srtas',
'ssg',
'ssgt',
'staff',
Expand Down Expand Up @@ -616,6 +649,7 @@
'vizier',
'vocalist',
'voice',
'vrouwe',
'warden',
'warrant',
'wing',
Expand Down