fix(cli): Patch generated Windows shell script for JAVACMD installs with spaces #7653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
changed the title
chadlwilson
force-pushed
the
fix-cli-windows-javacmd-quoting
branch
from
e2a57ee to
551b790
Compare
…ith spaces Workaround for mojohaus/appassembler#114 which seems to be unmaintained and stuck upstream. Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
chadlwilson
force-pushed
the
fix-cli-windows-javacmd-quoting
branch
from
551b790 to
f22d344
Compare
|
[OT] @jeremylong this is currently the last issue tagged for 12.1.2. Does that mean we can expect a new release soon? |
|
@marcelstoer sure - I'll try to go through the release process this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Workaround for mojohaus/appassembler#114 which seems to be unmaintained and stuck upstream. Essentially does the same as mojohaus/appassembler#115
Not ideal, but not sure if there is a better way to address the issue given the upstream status.
%CLASSPATH%will still have issues, but don't think it's worth the hassle to patch this given it should not be used with dep check.Related issues
Have test cases been added to cover the new functionality?
no
Manually compared generated zip before/after:
