Skip to content

Conversation

AbhishekBhaskar
Copy link
Contributor

What are you trying to accomplish?

This PR catches and displays a proper error message for UV's dependency resolution error.

The following error was being thrown in Sentry.
No solution found when resolving dependencies:
This fix now properly catches the error and converts it to DependencyFileNotResolvable error.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@AbhishekBhaskar AbhishekBhaskar self-assigned this Oct 14, 2025
@AbhishekBhaskar AbhishekBhaskar requested a review from a team as a code owner October 14, 2025 20:38

REQUIRED_FILES = %w(pyproject.toml uv.lock).freeze # At least one of these files should be present

UV_UNRESOLVABLE_REGEX = T.let(/No solution found when resolving dependencies:[\s\S]*$/, Regexp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this is correct fix? Do we know why we are getting No solution found when resolving dependencies ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@honeyankit this is a dependency resolution conflict in UV in the repository's manifest file. I've added proper error handling similar to how its being done in pnpm:

@AbhishekBhaskar AbhishekBhaskar merged commit 2616ba7 into main Oct 15, 2025
74 checks passed
@AbhishekBhaskar AbhishekBhaskar deleted the abhishekbhaskar/fix-uv-sentry-errors branch October 15, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants