Skip to content

fix(BREAKING): use which crate and drop resolving Deno to current exe #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 28, 2025

@dsherret dsherret marked this pull request as ready for review May 28, 2025 16:30
@dsherret dsherret requested a review from bartlomieju May 28, 2025 16:30
@dsherret dsherret changed the title refactor: use which crate fix(BREAKING): use which crate and drop resolving Deno to current exe May 28, 2025
// that don't have deno on the path and to ensure it use the current
// version of deno being executed rather than the one on the path,
// which has caused some confusion.
if command_name == EXECUTABLE_NAME {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll instead add "deno" as a custom command in the CLI.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants