new email

[r10s]

this PR adds an top-level option to create a new email with subject - this is the first time, we officially have that :)

the PR requires a core with chatmail/core#6932

• add 'new email' option to 'create chat' dialog
• adapt 'new group' dialog to email wording (members -> recipients, group name -> subject, create -> continue, title)
• list address contacts as recipients
• call new api
• test 

   

the last screenshot falls back to "group" wording, however, that seems okay for now. in a subsequent PR, if we see all that more in practise, we can consider to switch to "recipients" and "e-mail" also there (that would affect also incoming/existing chats, however)

the old "add contact manually" is removed on top-level by this PR - it is not a goal on its own, but part of a task the user wants to do. it is still possible to do "new contact / add contact manually", "scan qr code / add contact manually" and "new email / add recipients / add contact manually".
by the removal we have a cleaner, less cluttered UI and also in many cases, the user wants to set a subject, so "new email" is superior here

once this is merged, file issues for android/desktop

[adbenitez]

"new email"

it is not really an email but just creating an email thread

[r10s]

it is not really an email but just creating an email thread

sure, this is what it is internally.

so you suggest to reword to "New E-Mail Thread" in the UI? not sure if that is more or less helpful :)

eg. when thinking about german translation, it probably raises more questions than it solves

[adbenitez]

sure, this is what it is internally.

not internally but visible, you go through that steps as an unsuspecting user and didn't manage to create an email but a thread/group

so you suggest to reword to "New E-Mail Thread" in the UI?

yes that is what the action is actually doing, creating a group with classic email users which in the email world is called thread,

I think it is important to notice that this feature is not for the 99% of the users of Delta Chat but for the classic email users and will only appear to them, and they probably know what an email thread is

[link2xt]

The option should be hidden for chatmail profiles. Don't see the code checking it now.

[r10s]

and they probably know what an email thread is

i doubt, most typical email users know. at least ppl around me, in german language, do not know :) 🪡🧵 ...

this is the typical thing of ppl answering "Re: Merry Christmas" months later without context :)

what ppl actually want to do, is to "write an e-mail" - not to start an "e-mail thread" - one could also argue that even on classic email apps, "new e-mail" is not 100% correct, as that starts a new thread as well (in contrast to "reply"). so, i think, it is of some worth to pick up the same wording as in classic email apps. that all sounds a bit nitpicky to me :)

but i would not die on that hill, i see the point, and maybe our email users are different :) let's see if more voices come up, the string anyways needs to be changed in android repo

EDIT: in some 1:1 discussions, a plain "New E-Mail" was regarded to be superior, i'd stay with that for now

[r10s]

The option should be hidden for chatmail profiles. Don't see the code checking it now.

it is hidden for chatmail.

see NewChatViewController.swift, line 76:

        if self.dcContext.isChatmail == false {
            newOptions.append(.newEmail)
        }

[r10s]

k, core has been updated, this is read to review now

[Amzd]

This createEmail and createBroadcast could probably be consolidated into an enum? Or am I misunderstanding and is it possible to have both creatBroadcast: true and createEmail: true?

[r10s]

i still think, that is a minor, but i played around to see how it goes and added a commit :)

so, we have a createMode now