Skip to content

Conversation

@yschungmr
Copy link

Description:
This PR addresses a redundancy in the requirements.txt file by removing the duplicate declaration of the SentencePiece package. Currently, the package is listed twice:

  • As sentencepiece (lowercase, no version specified)
  • As SentencePiece==0.1.96 (with specific version)

Changes made:

  • Removed the unversioned sentencepiece entry
  • Retained SentencePiece==0.1.96 for version consistency

Rationale:

  • Python packages are case-insensitive, making these entries effectively duplicate
  • Keeping the versioned dependency ensures reproducible builds
  • This change maintains project stability while cleaning up the dependency list

Testing:

  • Verified that the project builds successfully with the updated requirements.txt
  • Confirmed all dependent functionality remains intact

Please review and merge if appropriate.

fix: remove duplicate SentencePiece package from requirements.txt
@Mohamezezo
Copy link

Withdraw

Copy link

@Karlie7538 Karlie7538 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ya makes sense lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants