[Refactor] Improve type safety with std::complex #6346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recent trial of including
f2c.h
leads to conflicts with the complex type defined theretypedef struct { real r, i; } complex;
.What's changed?
complex<double>
andcomplex<float>
occurrances including tests have been replaced bystd::complex<double>
andstd::complex<float>
complex<T>
without a space separation has been modified to have it. Example:double,complex<double>
is changed todouble, std::complex<double>
.Discussions
I had thought about using trick like
to do it, but it still has the same problem. So I stick to this more cumbersome.