Skip to content

Fix: reinterpret_cast bug for c10::complex<double>. #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2025
Merged

Fix: reinterpret_cast bug for c10::complex<double>. #6321

merged 2 commits into from
Jun 21, 2025

Conversation

ErjieWu
Copy link
Collaborator

@ErjieWu ErjieWu commented Jun 20, 2025

Linked Issue

Fix #6315.

What's changed?

  • Fix a bug cause by reinterpret c10 data type in DeePKS.
  • Add int support for tensor output in check_tensor().

@ErjieWu ErjieWu requested review from mohanchen and xuan112358 June 20, 2025 09:10
@mohanchen mohanchen added Bugs Bugs that only solvable with sufficient knowledge of DFT Machine Learning Issues related to the DeePKS labels Jun 21, 2025
@mohanchen
Copy link
Collaborator

Good job.

@mohanchen mohanchen merged commit 44ff32e into deepmodeling:develop Jun 21, 2025
14 checks passed
@ErjieWu ErjieWu deleted the fix branch June 23, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

@xuan112358 xuan112358 Awaiting requested review from xuan112358

Assignees
No one assigned
Labels
Bugs Bugs that only solvable with sufficient knowledge of DFT Machine Learning Issues related to the DeePKS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault of cal_v_delta_precalc when using mpiicpx&icpx compilers
2 participants
@ErjieWu @mohanchen