Skip to content

Combine relax_new with relax_old #6303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 18, 2025
Merged

Conversation

19hello
Copy link
Collaborator

@19hello 19hello commented Jun 17, 2025

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0 labels Jun 17, 2025
@dyzheng
Copy link
Collaborator

dyzheng commented Jun 18, 2025

Hello @19hello , you renamed relax_new/relax.h to relax.h and relax_old/relax_old.h to relax_old.h, I think it is not good names to distinguish these two method, I suggest to rename relax.h to relax_sync.h and relax_old.h to relax_nsync.h , because the main difference between them is synchronization or nsynchronization algorithm in cell-relax calculation.

@19hello
Copy link
Collaborator Author

19hello commented Jun 18, 2025

Hello @19hello , you renamed relax_new/relax.h to relax.h and relax_old/relax_old.h to relax_old.h, I think it is not good names to distinguish these two method, I suggest to rename relax.h to relax_sync.h and relax_old.h to relax_nsync.h , because the main difference between them is synchronization or nsynchronization algorithm in cell-relax calculation.

OK, I will change this tonight.

@mohanchen mohanchen merged commit fe44679 into deepmodeling:develop Jun 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants