pci:dp1000: Update the number of outbound and inbound #973
Conversation
Configure default maximum of 16 in and 16 out windows. Signed-off-by: Zhang Xincheng <zhangxincheng@ultrarisc.com> Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
|
Hi @WangJia-UR. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @WangJia-UR - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the PCI configuration for the dp1000 platform to support more inbound and outbound address translation unit (ATU) windows. The changes modify the default ATU size and address ranges to accommodate the increased window count.
- Sets default ATU size to 8KB to support up to 16 inbound and 16 outbound windows
- Fixes ATU window indexing in the host controller setup
- Increases memory range sizes in device tree from 5GB to 13GB for all PCIe controllers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pcie-ultrarisc.c | Sets default ATU size to 8KB with explanatory comment |
| pcie-designware-host.c | Fixes ATU window indexing from pre-increment to post-increment |
| dp1000.dts | Updates mem64 prefetchable ranges from 0x5 to 0xd (5GB to 13GB) |
| @@ -702,7 +702,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) | |||
| window_size = res_size > (pci->region_limit + 1) ? | |||
| (pci->region_limit + 1) : res_size; | |||
|
|
|||
| ret = dw_pcie_prog_outbound_atu(pci, ++i, PCIE_ATU_TYPE_MEM, | |||
| ret = dw_pcie_prog_outbound_atu(pci, i++, PCIE_ATU_TYPE_MEM, | |||
There was a problem hiding this comment.
Changing from ++i to i++ alters the behavior - the first ATU window will now use index 0 instead of index 1. Verify this is the intended behavior and that index 0 is valid for outbound ATU programming.
| ret = dw_pcie_prog_outbound_atu(pci, i++, PCIE_ATU_TYPE_MEM, | |
| ret = dw_pcie_prog_outbound_atu(pci, ++i, PCIE_ATU_TYPE_MEM, |
Copilot uses AI. Check for mistakes.
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RevySR The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review代码审查意见：
总体来说，这些更改看起来是有意为之，但是需要进一步的确认和测试以确保它们不会引入任何问题。 |
Update the number of outbound and inbound