Safer records #118
Open
Safer records #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example easily generates empty strings when changed to use new data, while dedupe expects None, leading to errors (dedupeio/dedupe#639 and dedupeio/affinegap#4). This is a simple patch that cleans the records, converting empty strings to None. Perhaps this could be used on CSV and other examples as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example easily generates empty strings when changed to use new data, while dedupe expects None, leading to errors (dedupeio/dedupe#639 and dedupeio/affinegap#4).
This is a simple patch that cleans the records, converting empty strings to None. Perhaps this could be used on CSV and other examples as well.