Skip to content

Change condition order in settings.php for Drupal #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Change condition order in settings.php for Drupal #50

merged 1 commit into from
Jun 13, 2025

Conversation

webflo
Copy link
Contributor

@webflo webflo commented Jun 13, 2025 •
edited by stasadev
Loading

The Issue

Align with the condition from the default ddev config. Check the env-var first and save the IO of file_exists.

How This PR Solves The Issue

Manual Testing Instructions

Using Drupal quickstart https://ddev.readthedocs.io/en/stable/users/quickstart/#drupal

ddev add-on get https://github.com/webflo/ddev-redis/tarball/patch-1
tail -n10 web/sites/default/settings.php
ddev restart

Automated Testing Overview

Release/Deployment Notes

stasadev
stasadev approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stasadev stasadev changed the title Change condition order in settings.php Change condition order in settings.php for Drupal Jun 13, 2025
@stasadev stasadev merged commit 59151bf into ddev:main Jun 13, 2025
20 checks passed
@webflo webflo deleted the patch-1 branch June 13, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasadev stasadev stasadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webflo @stasadev