Skip to content

Commit d6f2e32

Browse files
committed
[mlir] Flip Tensor dialect and ViewLike (NFC)
Also requires updating view like interface to use prefixed form. Differential Revision: https://reviews.llvm.org/D131361
1 parent b696500 commit d6f2e32

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

mlir/include/mlir/Dialect/Tensor/IR/TensorBase.td

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ def Tensor_Dialect : Dialect {
5151
"complex::ComplexDialect",
5252
];
5353

54-
// TODO: flip post changing ViewLike interface.
55-
let emitAccessorPrefix = kEmitAccessorPrefix_Both;
54+
let emitAccessorPrefix = kEmitAccessorPrefix_Prefixed;
5655
}
5756

5857
#endif // TENSOR_BASE

mlir/include/mlir/Interfaces/ViewLikeInterface.td

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
9393
/*args=*/(ins),
9494
/*methodBody=*/"",
9595
/*defaultImplementation=*/[{
96-
return $_op.offsets();
96+
return $_op.getOffsets();
9797
}]
9898
>,
9999
InterfaceMethod<
@@ -105,7 +105,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
105105
/*args=*/(ins),
106106
/*methodBody=*/"",
107107
/*defaultImplementation=*/[{
108-
return $_op.sizes();
108+
return $_op.getSizes();
109109
}]
110110
>,
111111
InterfaceMethod<
@@ -117,7 +117,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
117117
/*args=*/(ins),
118118
/*methodBody=*/"",
119119
/*defaultImplementation=*/[{
120-
return $_op.strides();
120+
return $_op.getStrides();
121121
}]
122122
>,
123123
InterfaceMethod<
@@ -129,7 +129,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
129129
/*args=*/(ins),
130130
/*methodBody=*/"",
131131
/*defaultImplementation=*/[{
132-
return $_op.static_offsets();
132+
return $_op.getStaticOffsets();
133133
}]
134134
>,
135135
InterfaceMethod<
@@ -141,7 +141,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
141141
/*args=*/(ins),
142142
/*methodBody=*/"",
143143
/*defaultImplementation=*/[{
144-
return $_op.static_sizes();
144+
return $_op.getStaticSizes();
145145
}]
146146
>,
147147
InterfaceMethod<
@@ -153,7 +153,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
153153
/*args=*/(ins),
154154
/*methodBody=*/"",
155155
/*defaultImplementation=*/[{
156-
return $_op.static_strides();
156+
return $_op.getStaticStrides();
157157
}]
158158
>,
159159
InterfaceMethod<
@@ -165,8 +165,8 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
165165
/*args=*/(ins),
166166
/*methodBody=*/"",
167167
/*defaultImplementation=*/[{
168-
return ::mlir::getMixedStridesOrOffsets($_op.static_offsets(),
169-
$_op.offsets());
168+
return ::mlir::getMixedStridesOrOffsets($_op.getStaticOffsets(),
169+
$_op.getOffsets());
170170
}]
171171
>,
172172
InterfaceMethod<
@@ -178,7 +178,7 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
178178
/*args=*/(ins),
179179
/*methodBody=*/"",
180180
/*defaultImplementation=*/[{
181-
return ::mlir::getMixedSizes($_op.static_sizes(), $_op.sizes());
181+
return ::mlir::getMixedSizes($_op.getStaticSizes(), $_op.sizes());
182182
}]
183183
>,
184184
InterfaceMethod<
@@ -190,8 +190,8 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
190190
/*args=*/(ins),
191191
/*methodBody=*/"",
192192
/*defaultImplementation=*/[{
193-
return ::mlir::getMixedStridesOrOffsets($_op.static_strides(),
194-
$_op.strides());
193+
return ::mlir::getMixedStridesOrOffsets($_op.getStaticStrides(),
194+
$_op.getStrides());
195195
}]
196196
>,
197197

0 commit comments

Comments
 (0)